[ https://issues.apache.org/jira/browse/PHOENIX-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187264#comment-16187264 ]
Rajeshbabu Chintaguntla commented on PHOENIX-4239: -------------------------------------------------- [~jamestaylor] bq. do you think it makes sense to check for index regions online only if the index table is in a DISABLE or PENDING_ACTIVE state (i.e. after a write failure when we haven't yet transitioned them)? Is that an expensive check to see if all regions are online? Yes it makes sense James. Checking for all region are online or not is definitely an expensive task because we need to touch RS calls equal to number of regions in the index table so better to check it only when the index is in DISABLE or PENDING_ACTIVE state. Once we are sure all regions online and ready for index rebuilding then we can transition further and continue rebuilding. > Fix flapping test in PartialIndexRebuilderIT > -------------------------------------------- > > Key: PHOENIX-4239 > URL: https://issues.apache.org/jira/browse/PHOENIX-4239 > Project: Phoenix > Issue Type: Test > Reporter: James Taylor > Assignee: James Taylor > Fix For: 4.12.0 > > Attachments: PHOENIX-4239.patch, PHOENIX-4239_v2.patch, > PHOENIX-4239_v3.patch, PHOENIX-4239_v4.patch, PHOENIX-4239_v5.patch > > > To get more info on this flapper: > https://www.google.com/url?q=https%3A%2F%2Fbuilds.apache.org%2Fjob%2FPhoenix-master%2F1810%2FtestReport%2Fjunit%2Forg.apache.phoenix.end2end.index%2FPartialIndexRebuilderIT%2FtestIndexWriteFailureLeavingIndexActive%2F&sa=D&sntz=1&usg=AFQjCNEj0LexiK8bm4GzGex9JUvu0DBJag -- This message was sent by Atlassian JIRA (v6.4.14#64029)