[
https://issues.apache.org/jira/browse/PHOENIX-4277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213116#comment-16213116
]
Hadoop QA commented on PHOENIX-4277:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12893327/PHOENIX-4277_v3.patch
against master branch at commit 7cdcb2313b08d2eaeb775f0c989642f8d416cfb6.
ATTACHMENT ID: 12893327
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ return new ScanInfo(scanInfo.getConfiguration(),
scanInfo.getFamily(), Math.max(scanInfo.getMinVersions(), 1),
+ public KeyValueScanner preStoreScannerOpen(final
ObserverContext<RegionCoprocessorEnvironment> c,
+ if (scan.isRaw() || ScanInfoUtil.isKeepDeletedCells(store.getScanInfo())
|| scan.getTimeRange().getMax() == HConstants.LATEST_TIMESTAMP ||
TransactionUtil.isTransactionalTimestamp(scan.getTimeRange().getMax())) {
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1564//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1564//console
This message is automatically generated.
> Treat delete markers consistently with puts for point-in-time scans
> -------------------------------------------------------------------
>
> Key: PHOENIX-4277
> URL: https://issues.apache.org/jira/browse/PHOENIX-4277
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: James Taylor
> Fix For: 4.13.0
>
> Attachments: PHOENIX-4277_v2.patch, PHOENIX-4277_v3.patch,
> PHOENIX-4277_wip.patch
>
>
> The IndexScrutinyTool relies on doing point-in-time scans to determine
> consistency between the index and data tables. Unfortunately, deletes to the
> tables cause a problem with this approach, since delete markers take effect
> even if they're at a later time stamp than the point-in-time at which the
> scan is being done (unless KEEP_DELETED_CELLS is true). The logic of this is
> that scans should get the same results before and after a compaction take
> place.
> Taking snapshots does not help with this since they cannot be taken at a
> point-in-time and the delete markers will act the same way - there's no way
> to guarantee that the index and data table snapshots have the same "logical"
> set of data.
> Using raw scans would allow us to see the delete markers and do the correct
> point-in-time filtering ourselves. We'd need to write the filters to do this
> correctly (see the Tephra TransactionVisibilityFilter for an implementation
> of this that could be adapted). We'd also need to hook this into Phoenix or
> potentially dip down to the HBase level to do this.
> Thanks for brainstorming on this with me, [~lhofhansl].
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
