[
https://issues.apache.org/jira/browse/PHOENIX-4237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213121#comment-16213121
]
Hadoop QA commented on PHOENIX-4237:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12893307/PHOENIX-4237_v1.patch
against master branch at commit 7cdcb2313b08d2eaeb775f0c989642f8d416cfb6.
ATTACHMENT ID: 12893307
{color:red}-1 @author{color}. The patch appears to contain 17 @author tags
which the Hadoop community has agreed to not allow in code contributions.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ queryWithCollKeyDefaultArgsWithExpectedOrder("zh_TW", 0, 6, new
Integer[] { 0, 3, 4, 1, 5, 2, 6 });
+ queryWithCollKeyDefaultArgsWithExpectedOrder("zh_TW_STROKE", 0,
6, new Integer[] { 4, 2, 0, 3, 1, 6, 5 });
+ queryWithCollKeyDefaultArgsWithExpectedOrder("zh__STROKE", 0,
6, new Integer[] { 0, 1, 3, 4, 6, 2, 5 });
+ queryWithCollKeyDefaultArgsWithExpectedOrder("zh__PINYIN", 0,
6, new Integer[] { 0, 1, 3, 4, 6, 2, 5 });
+ queryWithCollKeyUpperCaseWithExpectedOrder("en", 7, 13, new
Integer[] { 7, 10, 11, 13, 9, 12, 8 });
+ private void queryWithCollKeyDefaultArgsWithExpectedOrder(String
localeString, Integer beginIndex, Integer endIndex,
+ "SELECT id, data FROM %s WHERE ID BETWEEN %d
AND %d ORDER BY COLLATION_KEY(data, '%s')", tableName,
+ private void queryWithCollKeyUpperCaseWithExpectedOrder(String
localeString, Integer beginIndex, Integer endIndex,
+ "SELECT id, data FROM %s WHERE ID BETWEEN %d
AND %d ORDER BY COLLATION_KEY(data, '%s', true), id",
+ private void queryWithCollKeyWithStrengthWithExpectedOrder(String
localeString, Integer strength, boolean isDescending,
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.phoenix.expression.function.CollationKeyFunctionTest
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1563//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1563//console
This message is automatically generated.
> Allow sorting on (Java) collation keys for non-English locales
> --------------------------------------------------------------
>
> Key: PHOENIX-4237
> URL: https://issues.apache.org/jira/browse/PHOENIX-4237
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Fix For: 4.12.0
>
> Attachments: PHOENIX-4237_v1.patch
>
>
> Strings stored via Phoenix can be composed from a subset of the entire set of
> Unicode characters. The natural sort order for strings for different
> languages often differs from the order dictated by the binary representation
> of the characters of these strings. Java provides the idea of a Collator
> which given an input string and a (language) locale can generate a Collation
> Key which can then be used to compare strings in that natural order.
> Salesforce has recently open-sourced grammaticus. IBM has open-sourced ICU4J
> some time ago. These technologies can be combined to provide a robust new
> Phoenix function that can be used in an ORDER BY clause to sort strings
> according to the user's locale.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
