[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226207#comment-16226207 ]
Hadoop QA commented on PHOENIX-4287: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12894902/PHOENIX-4287_v3_wip.patch against master branch at commit a7af29f9e90308d5a2805cc3eabf4e607fbe3cb2. ATTACHMENT ID: 12894902 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: +// boolean startNewScan = scanGrouper.shouldStartNewScan(plan, scans, startKey, crossedRegionBoundary); +// scan.setAttribute(BaseScannerRegionObserver.SCAN_REGION_SERVER, regionLocation.getServerName().getVersionedBytes()); + scans = addNewScan(parallelScans, scans, newScan, endKey, true, regionLocation, null, null, null); + scans = addNewScan(parallelScans, scans, newScan, endKey, true, regionLocation, null, null, null); {color:red}-1 core tests{color}. The patch failed these unit tests: ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1594//testReport/ Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1594//console This message is automatically generated. > Incorrect aggregate query results when stats are disable for parallelization > ---------------------------------------------------------------------------- > > Key: PHOENIX-4287 > URL: https://issues.apache.org/jira/browse/PHOENIX-4287 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.12.0 > Environment: HBase 1.3.1 > Reporter: Mujtaba Chohan > Assignee: Samarth Jain > Labels: localIndex > Fix For: 4.12.1 > > Attachments: PHOENIX-4287.patch, PHOENIX-4287_v2.patch, > PHOENIX-4287_v3_wip.patch > > > With {{phoenix.use.stats.parallelization}} set to {{false}}, aggregate query > returns incorrect results when stats are available. > With local index and stats disabled for parallelization: > {noformat} > explain select count(*) from TABLE_T; > +-------------------------------------------------------------------------------------------------------+-----------------+----------------+-----------+ > | PLAN > | EST_BYTES_READ | EST_ROWS_READ | EST_INFO | > +-------------------------------------------------------------------------------------------------------+-----------------+----------------+-----------+ > | CLIENT 0-CHUNK 332170 ROWS 625043899 BYTES PARALLEL 0-WAY RANGE SCAN OVER > TABLE_T [1] | 625043899 | 332170 | 150792825 | > | SERVER FILTER BY FIRST KEY ONLY > | 625043899 | 332170 | 150792825 | > | SERVER AGGREGATE INTO SINGLE ROW > | 625043899 | 332170 | 150792825 | > +-------------------------------------------------------------------------------------------------------+-----------------+----------------+-----------+ > select count(*) from TABLE_T; > +-----------+ > | COUNT(1) | > +-----------+ > | 0 | > +-----------+ > {noformat} > Using data table > {noformat} > explain select /*+NO_INDEX*/ count(*) from TABLE_T; > +--------------------------------------------------------------------------------------------------+-----------------+----------------+----------------+ > | PLAN > | EST_BYTES_READ | EST_ROWS_READ | EST_INFO_TS | > +--------------------------------------------------------------------------------------------------+-----------------+----------------+----------------+ > | CLIENT 2-CHUNK 332151 ROWS 438492470 BYTES PARALLEL 1-WAY FULL SCAN OVER > TABLE_T | 438492470 | 332151 | 1507928257617 | > | SERVER FILTER BY FIRST KEY ONLY > | 438492470 | 332151 | 1507928257617 | > | SERVER AGGREGATE INTO SINGLE ROW > | 438492470 | 332151 | 1507928257617 | > +--------------------------------------------------------------------------------------------------+-----------------+----------------+----------------+ > select /*+NO_INDEX*/ count(*) from TABLE_T; > +-----------+ > | COUNT(1) | > +-----------+ > | 14 | > +-----------+ > {noformat} > Without stats available, results are correct: > {noformat} > explain select /*+NO_INDEX*/ count(*) from TABLE_T; > +----------------------------------------------------------------------+-----------------+----------------+--------------+ > | PLAN | > EST_BYTES_READ | EST_ROWS_READ | EST_INFO_TS | > +----------------------------------------------------------------------+-----------------+----------------+--------------+ > | CLIENT 2-CHUNK PARALLEL 1-WAY FULL SCAN OVER TABLE_T | null | > null | null | > | SERVER FILTER BY FIRST KEY ONLY | null > | null | null | > | SERVER AGGREGATE INTO SINGLE ROW | null > | null | null | > +----------------------------------------------------------------------+-----------------+----------------+--------------+ > select /*+NO_INDEX*/ count(*) from TABLE_T; > +-----------+ > | COUNT(1) | > +-----------+ > | 333327 | > +-----------+ > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)