[
https://issues.apache.org/jira/browse/PHOENIX-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233819#comment-16233819
]
Hadoop QA commented on PHOENIX-4335:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12895094/PHOENIX-4335_v2.patch
against master branch at commit a39633169b75ceef340782379dd6c3c51d960142.
ATTACHMENT ID: 12895094
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ public PhoenixUpgradeCountingServices(QueryServices services,
ConnectionInfo connectionInfo, Properties info) {
+ public synchronized ConnectionQueryServices
getConnectionQueryServices(String url, Properties info) throws SQLException {
+ cqs = new PhoenixUpgradeCountingServices(new
QueryServicesTestImpl(getDefaultProps(), overrideProps),
ConnectionInfo.create(url), info);
+ ConnectionQueryServices services =
DriverManager.getConnection(getUrl()).unwrap(PhoenixConnection.class).getQueryServices();
+ boolean wasTimestampChanged = systemTableVersion[0] !=
MetaDataProtocol.MIN_SYSTEM_TABLE_TIMESTAMP;
+ // Confirm that another connection does not increase the number of
times upgrade was attempted
+
metaConnection.createStatement().executeUpdate(getSystemCatalogDML());
+ protected static String setUpTestCluster(@Nonnull Configuration conf,
ReadOnlyProps overrideProps) throws Exception {
+ private static String initMiniCluster(Configuration conf, ReadOnlyProps
overrideProps) throws Exception {
+ private static String initClusterDistributedMode(Configuration conf,
ReadOnlyProps overrideProps) throws Exception {
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1600//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1600//console
This message is automatically generated.
> System catalog snapshot created each time a new connection is created
> ---------------------------------------------------------------------
>
> Key: PHOENIX-4335
> URL: https://issues.apache.org/jira/browse/PHOENIX-4335
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.12.0
> Reporter: Mujtaba Chohan
> Assignee: James Taylor
> Priority: Blocker
> Fix For: 4.13.0
>
> Attachments: PHOENIX-4335.patch, PHOENIX-4335_v2.patch
>
>
> With current head of 4.x, System Catalog snapshot is created on each new
> connection.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
