[ 
https://issues.apache.org/jira/browse/PHOENIX-4424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274066#comment-16274066
 ] 

ASF GitHub Bot commented on PHOENIX-4424:
-----------------------------------------

Github user ankitsinghal commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/284#discussion_r154282569
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
    @@ -4125,7 +4125,7 @@ public MutationState 
createSchema(CreateSchemaStatement create) throws SQLExcept
     
         private void validateSchema(String schemaName) throws SQLException {
             if (SchemaUtil.NOT_ALLOWED_SCHEMA_LIST.contains(
    -                schemaName.toUpperCase())) { throw new 
SQLExceptionInfo.Builder(SQLExceptionCode.SCHEMA_NOT_ALLOWED)
    --- End diff --
    
    @karanmehta93 , I tried case-sensitive schemas with master code, I don't 
see any problem. can you check if normalization is happening at some other(or 
not at the right) place?
    ```
    0: jdbc:phoenix:localhost> create schema "ABC";
    No rows affected (0.224 seconds)
    ```
    ```
    0: jdbc:phoenix:localhost> select TABLE_SCHEM from system.catalog;
    +--------------+
    | TABLE_SCHEM  |
    +--------------+
    | ABC          |
    ```
    ```
    hbase(main):002:0> list_namespace
    NAMESPACE
    ABC
    ```
    ```
    0: jdbc:phoenix:localhost> create schema "small_case"
    . . . . . . . . . . . . .> ;
    No rows affected (0.424 seconds)
    0: jdbc:phoenix:localhost> select TABLE_SCHEM from system.catalog;
    +--------------+
    | TABLE_SCHEM  |
    +--------------+
    | small_case   |
    
    hbase(main):003:0> list_namespace
    NAMESPACE
    small_case
    ```



> Allow users to create "DEFAULT" and "HBASE" Schema (Uppercase Schema Names)
> ---------------------------------------------------------------------------
>
>                 Key: PHOENIX-4424
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4424
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Karan Mehta
>            Assignee: Karan Mehta
>         Attachments: PHOENIX-4424.001.patch
>
>
> We currently block users to create "DEFAULT" and "HBASE" schema, however it 
> should be actually "default" and "hbase" since hbase namespace is case 
> sensitive. Hence we should update it and allow is users want to create 
> schema's with those names.
> If user wants to access the schema names with capital letters, they can pass 
> it in directly (Phoenix will automatically upper-case it) or pass it in 
> uppercase letters with double-quotes.
> FYI.
> [[email protected]]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to