[ 
https://issues.apache.org/jira/browse/PHOENIX-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279396#comment-16279396
 ] 

Hadoop QA commented on PHOENIX-4382:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12900763/PHOENIX-4382.v1.master.patch
  against master branch at commit d77c237b560900671c3a9c58f6f2398342655e8a.
  ATTACHMENT ID: 12900763

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release 
audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +    private <T extends Number> void testValues(boolean immutable, 
PDataType<?> dataType, List<T> testData) throws Exception {
+                    (initPos + ptr.getLength() - (Bytes.SIZEOF_BYTE + 2 * 
Bytes.SIZEOF_INT))) + initPos;

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.phoenix.schema.ImmutableStorageSchemeTest

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1653//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1653//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1653//console

This message is automatically generated.

> Upsert of some big values not correct for immutable tables
> ----------------------------------------------------------
>
>                 Key: PHOENIX-4382
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4382
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.14.0
>            Reporter: Vincent Poon
>            Assignee: Vincent Poon
>         Attachments: PHOENIX-4382.v1.master.patch, UpsertBigValuesIT.java
>
>
> For immutable tables, upsert of some values like Short.MAX_VALUE results in a 
> null value in query resultsets.  Mutable tables are not affected.  I tried 
> with BigInt and got the same problem.
> For Short, the breaking point seems to be 32512.  Numbers smaller than that 
> are fine (until you get closer to Short.MIN_VALUE...)
> See attached test - testShort() , testBigInt()



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to