[ 
https://issues.apache.org/jira/browse/PHOENIX-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286834#comment-16286834
 ] 

Josh Elser commented on PHOENIX-4449:
-------------------------------------

bq.  2. We should not set a default value for zookeeper parent because if it's 
not specified in the command line, those values should be obtained from hbase 
client (hbase-site.xml or default values if it's not in the classpath).

This isn't a regression is it, [~sergey.soldatov]? I'm just looking back at old 
versions -- we just would've errored out if you didn't provide it explicitly. 
Wanted to make sure I wasn't missing anything.

sqlline-thin does exec out to org.apache.hadoop.hbase.util.HBaseConfTool to get 
the value of wire serialization for avatica from hbase-site.xml. We could do 
the same trick for the ZK quorum and root node...

> Incorrect behavior of sqlline after PHOENIX-3567
> ------------------------------------------------
>
>                 Key: PHOENIX-4449
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4449
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.10.0, 4.13.0, 5.0.0
>            Reporter: Sergey Soldatov
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: 5.0.0, 4.14.0
>
>
> In PHOENIX-3567 we have introduced a usage of argparse in sqlline as well as 
> some default values for the parameters. That's not good because of:
> 1. argparse is not a default package in old versions of python like 2.6.6 
> which is using in centos 6 distribution. 
> 2. We should not set a default value for zookeeper parent because if it's not 
> specified in the command line, those values should be obtained from hbase 
> client (hbase-site.xml or default values if it's not in the classpath).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to