[
https://issues.apache.org/jira/browse/PHOENIX-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293757#comment-16293757
]
Pedro Boado edited comment on PHOENIX-4372 at 12/16/17 12:29 PM:
-----------------------------------------------------------------
[~jamestaylor]
{quote}Yes, we use rat plugin as a pre release step to verify that all required
files have the ASF header. Are the 713 files new files? Does the rat check pass
for 4.13-HBase-1.2? Are they occurring on new files you've added? Some files
are ok to not have the header if it's not feasible to have it, but if it can be
added, we add it.{quote}
-Yep 4.13-HBase-1.2 also fails- Actually it was my fault ( rat plugin is not
ignoring .git and .idea folders and I was executing it in my work folder ) ...
There are only ~10 files with problems, I'll create a subtask and atach a patch.
was (Author: pboado):
[~jamestaylor]
{quote}Yes, we use rat plugin as a pre release step to verify that all required
files have the ASF header. Are the 713 files new files? Does the rat check pass
for 4.13-HBase-1.2? Are they occurring on new files you've added? Some files
are ok to not have the header if it's not feasible to have it, but if it can be
added, we add it.{quote}
Yep 4.13-HBase-1.2 also fails
> Distribution of Apache Phoenix 4.13 for CDH 5.11.2
> --------------------------------------------------
>
> Key: PHOENIX-4372
> URL: https://issues.apache.org/jira/browse/PHOENIX-4372
> Project: Phoenix
> Issue Type: Task
> Affects Versions: 4.13.0
> Reporter: Pedro Boado
> Assignee: Pedro Boado
> Priority: Minor
> Labels: cdh
> Attachments: PHOENIX-4372-v2.patch, PHOENIX-4372-v3.patch,
> PHOENIX-4372-v4.patch, PHOENIX-4372-v5.patch, PHOENIX-4372-v6.patch,
> PHOENIX-4372-v7.patch, PHOENIX-4372.patch
>
>
> Changes required on top of branch 4.13-HBase-1.2 for creating a parcel of
> Apache Phoenix 4.13.0 for CDH 5.11.2 .
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
