[
https://issues.apache.org/jira/browse/PHOENIX-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297737#comment-16297737
]
Hadoop QA commented on PHOENIX-4468:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12902948/PHOENIX-4468-v3-4.x-HBase-0.98.patch
against 4.x-HBase-0.98 branch at commit
9d8be0e9214ba3680a81c399c5da316c1b91c99b.
ATTACHMENT ID: 12902948
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ conf.set(QueryServices.EXTRA_JDBC_ARGUMENTS_ATTRIB,
QueryServicesOptions.DEFAULT_EXTRA_JDBC_ARGUMENTS);
+ public Connection createConnection(boolean isMultiTenant, boolean
isDifferentClient) throws SQLException {
+ conn.createStatement().execute("CREATE SEQUENCE " + sequenceName + "
START WITH 3 INCREMENT BY 2 CACHE 5");
+ query = "SELECT CURRENT_VALUE FROM \"SYSTEM\".\"SEQUENCE\" WHERE
SEQUENCE_SCHEMA=? AND SEQUENCE_NAME=?";
+ public void helpTestViewParentIndexLookupMutipleClients(boolean
isMultiTenant) throws Exception {
+ globalConn.createStatement().execute("CREATE INDEX " +
baseTableIndexName + " ON " + baseTableName + " (V2) INCLUDE (v1, V3)");
+ String viewDDL = "CREATE VIEW " + viewName + " AS SELECT * FROM "
+ baseTableName + " WHERE V1 = 'X'";
+ String expectedTableName = baseTableIndexName +
QueryConstants.CHILD_VIEW_INDEX_NAME_SEPARATOR + viewName;
+ if (c.contains(QueryConstants.CHILD_VIEW_INDEX_NAME_SEPARATOR) ) {
throw new RuntimeException("Table or schema name cannot contain hash"); }
+ tenantId, PNameImpl.EMPTY_NAME, tableName,
table.getType(), table.getIndexState(), timeStamp,
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.ViewIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexReplicationIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.ChildViewsUseParentViewIndexIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1681//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1681//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1681//console
This message is automatically generated.
> Looking up a parent index table of a child view from a different client
> fails.
> -------------------------------------------------------------------------------
>
> Key: PHOENIX-4468
> URL: https://issues.apache.org/jira/browse/PHOENIX-4468
> Project: Phoenix
> Issue Type: Bug
> Reporter: Thomas D'Silva
> Assignee: Thomas D'Silva
> Fix For: 4.14.0, 4.13.2
>
> Attachments: PHOENIX-4468-4.x-HBase-0.98.patch,
> PHOENIX-4468-v2-4.x-HBase-0.98.patch, PHOENIX-4468-v3-4.x-HBase-0.98.patch
>
>
> When you execute a query on a view, phoenix will use any indexes on the base
> table that have all the required columns. We create a new PTable based on the
> parent table index and tack on the view statement (to ensure we only see rows
> that we can access from the view). This PTable is added to the client side
> connection metadata cache. This table is not available on the server side (in
> SYSTEM.CATALOG).
> If you lookup the parent index table from a different client (that never ran
> a query on the view), it will fail with a TableNotFoundException.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
