[
https://issues.apache.org/jira/browse/PHOENIX-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300555#comment-16300555
]
Hadoop QA commented on PHOENIX-4398:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12903294/PHOENIX-4398_V1.patch
against master branch at commit 9355a4d262d31d8d65e1467bcc351bb99760e11d.
ATTACHMENT ID: 12903294
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ private static Configuration config =
HBaseFactoryProvider.getConfigurationFactory().getConfiguration();
+ private static boolean use_compile_parallel =
config.getBoolean(USE_COMPILE_COLUMN_EXPRESSION_PARALLEL,
+ expressions[i++] = ((ProjectedColumn)
column).getSourceColumnRef().newColumnExpression();
+ return new ExpressionOrder(((ProjectedColumn)
column).getSourceColumnRef().newColumnExpression(), order);
+ public static final String USE_COMPILE_COLUMN_EXPRESSION_PARALLEL =
"phoenix.use.columnexpression.parallel";
+ public static final String COMPILE_COLUMN_EXPRESSION_PARALLEL_THREAD =
"phoenix.columnexpression.parallel.thread";
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1684//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1684//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1684//console
This message is automatically generated.
> Change QueryCompiler get column expressions process from serial to parallel.
> ----------------------------------------------------------------------------
>
> Key: PHOENIX-4398
> URL: https://issues.apache.org/jira/browse/PHOENIX-4398
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.11.0, 4.13.0
> Reporter: Albert Lee
> Fix For: 4.11.0, 4.13.0
>
> Attachments: PHOENIX-4398.patch, PHOENIX-4398_V1.patch
>
>
> When QueryCompiler compile a select sql, the process of getting column
> expressions is a serial process. The performance is ok when the table is
> narrow. But when compile a wide table(e.g. 130 columns in my use case), The
> time-consuming of this step is very high, over 70ms. So I change
> TupleProjector(PTable projectedTable) from serial for loop to parallel future.
> Because this is just modify code performance, not add new feture, so there is
> no unit test.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
