[ 
https://issues.apache.org/jira/browse/PHOENIX-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304281#comment-16304281
 ] 

Anoop Sam John commented on PHOENIX-4399:
-----------------------------------------

Changing IndexBuildingFailureException  to be a RTE is fine with the assumption 
that it is been thrown only from this one place.
bq. throw new RuntimeException(errormsg);
Same way can u throw a Phoenix specific RTE? If can not be 
IndexBuildingFailureException, a new one which is RTE
Else patch looks fine.

> Remove explicit abort on RegionServerServices
> ---------------------------------------------
>
>                 Key: PHOENIX-4399
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4399
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>              Labels: HBase-2.0
>         Attachments: PHOENIX-4399.patch
>
>
> Suggestions from @stack and [~anoop.hbase] from HBASE-18298
> Though regionServerServices are not visible from the environment, we can 
> still let CoprocessorHost abort the RS if observer/coprocessor throws 
> exception other than IOException and hbase.coprocessor.abortonerror is not 
> set to false. 
> But how to ensure that ABORT_ON_ERROR is never set to false in case of 
> Phoenix. or should we have some special exception in HBase for forcefull 
> abort.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to