[ 
https://issues.apache.org/jira/browse/PHOENIX-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331824#comment-16331824
 ] 

Ankit Singhal commented on PHOENIX-4519:
----------------------------------------

bq. Have these been incorporated in the MR partial index rebuild code path? 
Yes. IndexTool was extended with an option for a partial rebuild. 
https://issues.apache.org/jira/browse/PHOENIX-2890

bq. Do we have unit tests for the MR partial index rebuilder? Can we run the 
PartialIndexRebuilderIT tests using the MR-based rebuilder?
Yes, IndexToolForPartialBuildIT is for partial index rebuilder only

bq. Has the documentation been updated here: 
https://phoenix.apache.org/secondary_indexing.html?
Not yet, I regret the same. I have some documentation pending for 2-3 features 
(Phoenix ACLs is another). Let me try to update them all this weekend.

bq. Can we do some refactoring so that the code can be shared between 
MetaDataRegionObserver and the MR partial index rebuilder?
yes, we can do that. there is a lot of overlap between 
PhoenixIndexPartialBuildMapper and MetaDataRegionObserver

bq. How does the MR based partial index rebuilder handle clearing the 
INDEX_DISABLE_TIMESTAMP? For example, what if one of the map tasks fails while 
others succeed?
We mark the index as active in a single reducer when all map tasks are 
completed.

bq. Does the MR base rebuilder wait until all the index regions are back online 
before starting?
some Map will not progress until all the regions are up or may fail eventually 
after some retries.

bq. Are all the various rebuild options supported by the MR partial rebuilder 
(leaving the index active while rebuilding, allowing this option to be 
configured on a per table basis)?
I'm not aware of this option so probably not supported. In MR partial 
rebuilder, Index will be inactive until the rebuild completes, it will keep on 
accepting the writes but not serve any queries. 







> Index rebuild MR jobs not created for "alter index rebuild async" rebuilds
> --------------------------------------------------------------------------
>
>                 Key: PHOENIX-4519
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4519
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Vincent Poon
>            Assignee: Vincent Poon
>            Priority: Major
>
> It seems we have two ASYNC flags for index rebuilds:
> ASYNC_CREATED_DATE - when an index is created async
> ASYNC_REBUILD_TIMESTAMP - created by "alter index ... rebuild async"
> The PhoenixMRJobSubmitter only submits MR jobs for the former.  We should 
> also submit jobs for the latter.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to