[
https://issues.apache.org/jira/browse/PHOENIX-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340434#comment-16340434
]
ASF GitHub Bot commented on PHOENIX-4130:
-----------------------------------------
GitHub user vincentpoon opened a pull request:
https://github.com/apache/phoenix/pull/290
PHOENIX-4130 Avoid server retries for mutable indexes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vincentpoon/phoenix PHOENIX-4130
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/phoenix/pull/290.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #290
----
commit cb86a5b6a42e3c3a62d75851499a1460b241d623
Author: Vincent Poon <vincentpoon@...>
Date: 2018-01-26T01:25:09Z
PHOENIX-4130 Avoid server retries for mutable indexes
----
> Avoid server retries for mutable indexes
> ----------------------------------------
>
> Key: PHOENIX-4130
> URL: https://issues.apache.org/jira/browse/PHOENIX-4130
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Lars Hofhansl
> Assignee: Vincent Poon
> Priority: Major
> Fix For: 4.14.0
>
> Attachments: PHOENIX-4130.v1.master.patch,
> PHOENIX-4130.v2.master.patch
>
>
> Had some discussions with [~jamestaylor], [~samarthjain], and [~vincentpoon],
> during which I suggested that we can possibly eliminate retry loops happening
> at the server that cause the handler threads to be stuck potentially for
> quite a while (at least multiple seconds to ride over common scenarios like
> splits).
> Instead we can do the retries at the Phoenix client that.
> So:
> # The index updates are not retried on the server. (retries = 0)
> # A failed index update would set the failed index timestamp but leave the
> index enabled.
> # Now the handler thread is done, it throws an appropriate exception back to
> the client.
> # The Phoenix client can now retry. When those retries fail the index is
> disabled (if the policy dictates that) and throw the exception back to its
> caller.
> So no more waiting is needed on the server, handler threads are freed
> immediately.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
