[ https://issues.apache.org/jira/browse/PHOENIX-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364028#comment-16364028 ]
Ohad Shacham commented on PHOENIX-4605: --------------------------------------- initTxServiceClient is calling function setTransactionClient that was declared at the TAL. It uses the TransactionFactory to get the context and the TransactionFactory generates the context according to the defined transaction processor. Is it possible to set the transaction processor inside the TransactionFactory and leave this code as it is? Read an option for hbase_site.xml? This way we have a var that defines whether to use transactions and one (inside the TransactionFactory) that defines which transaction processor to use. What do you say [~jamestaylor]? > Add TRANSACTION_PROVIDER and DEFAULT_TRANSACTION_PROVIDER instead of using > boolean > ---------------------------------------------------------------------------------- > > Key: PHOENIX-4605 > URL: https://issues.apache.org/jira/browse/PHOENIX-4605 > Project: Phoenix > Issue Type: Bug > Reporter: James Taylor > Priority: Major > > We should deprecate QueryServices.DEFAULT_TABLE_ISTRANSACTIONAL_ATTRIB and > instead have a QueryServices.DEFAULT_TRANSACTION_PROVIDER now that we'll have > two transaction providers: Tephra and Omid. Along the same lines, we should > add a TRANSACTION_PROVIDER column to SYSTEM.CATALOG and stop using the > IS_TRANSACTIONAL table property. For backwards compatibility, we can assume > the provider is Tephra if the existing properties are set to true. -- This message was sent by Atlassian JIRA (v7.6.3#76005)