[
https://issues.apache.org/jira/browse/PHOENIX-4505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16401066#comment-16401066
]
James Taylor commented on PHOENIX-4505:
---------------------------------------
Looks good, but minor nit: how about just calling s.close() outside the if
statement instead of repeating?
> IndexHalfStoreFileReaderGenerator.preStoreScannerOpen does not close the
> passed in KeyValueScanner while creating and returning a new scanner
> ---------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-4505
> URL: https://issues.apache.org/jira/browse/PHOENIX-4505
> Project: Phoenix
> Issue Type: Bug
> Reporter: Thomas D'Silva
> Assignee: Thomas D'Silva
> Priority: Major
> Attachments: PHOENIX-4505.patch
>
>
> [~jamestaylor]
> preCompactScannerOpen also does not close the InternalScanner that is passed
> in before creating and returning a new scanner, does that scanner need to be
> closed as well?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
