[ 
https://issues.apache.org/jira/browse/PHOENIX-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405832#comment-16405832
 ] 

Ankit Singhal commented on PHOENIX-4576:
----------------------------------------

[~elserj] , a week ago,  I shared my feedback on the patch with [~rajeshbabu] 
and he has been working on fixing the same.

As discussed with him, Following case will fail with the above fix:-

There are two region r1(a.. aaad) and r2(aaad ... def) which are getting 
merged, if in this case, let's say the startrow of the scan is "a" , then scan 
will match with both the region even if r2 needs to be skipped here.
{code:java}
+ if (Bytes.compareTo(scan.getStartRow(), 0, startKey.length == 0 ? 
endKey.length
+                       : startKey.length, startKey.length == 0 ? new 
byte[endKey.length] : startKey, 0,
+                   startKey.length == 0 ? endKey.length : startKey.length) != 
0) {
+                   return keyValueScanners;
+               }{code}
 

 

> Fix LocalIndexSplitMergeIT tests failing in master branch
> ---------------------------------------------------------
>
>                 Key: PHOENIX-4576
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4576
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Rajeshbabu Chintaguntla
>            Priority: Major
>             Fix For: 4.14.0
>
>         Attachments: PHOENIX-4576.patch, PHOENIX-4576_v2.patch
>
>
> Currenty LocalIndexSplitMergeIT#testLocalIndexScanAfterRegionsMerge is 
> failing in master branch. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to