[
https://issues.apache.org/jira/browse/PHOENIX-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424491#comment-16424491
]
ASF GitHub Bot commented on PHOENIX-4579:
-----------------------------------------
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/295#discussion_r178933517
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -1039,10 +1065,20 @@ private HTableDescriptor ensureTableCreated(byte[]
physicalTableName, PTableType
}
}
+ if (isMetaTable &&
SchemaUtil.isNamespaceMappingEnabled(PTableType.SYSTEM,
--- End diff --
The ensureSystemTablesMigratedToSystemNamespace has race conditions in the
case of multiple clients executing it at the same time. We should treat this as
an upgrade step and do it while we have the SYSTEM.MUTEX lock (which ensures
only a single client will be executing upgrade code).
> Add a config to conditionally create Phoenix meta tables on first client
> connection
> -----------------------------------------------------------------------------------
>
> Key: PHOENIX-4579
> URL: https://issues.apache.org/jira/browse/PHOENIX-4579
> Project: Phoenix
> Issue Type: New Feature
> Reporter: Mujtaba Chohan
> Assignee: Chinmay Kulkarni
> Priority: Major
> Attachments: PHOENIX-4579.patch
>
>
> Currently we create/modify Phoenix meta tables on first client connection.
> Adding a property to make it configurable (with default true as it is
> currently implemented).
> With this property set to false, it will avoid lockstep upgrade requirement
> for all clients when changing meta properties using PHOENIX-4575 as this
> property can be flipped back on once all the clients are upgraded.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
