[
https://issues.apache.org/jira/browse/PHOENIX-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440009#comment-16440009
]
Josh Elser commented on PHOENIX-4423:
-------------------------------------
{code:java}
+// sb.append("set hive.optimize.index.filter=false;" +
HiveTestUtil.CRLF);
+// sb.append("set hive.optimize.ppd=false;" + HiveTestUtil.CRLF){code}
Nit: remove. Two instances of it.
{code:java}
-
+ try {
+ Class.forName("org.apache.phoenix.jdbc.PhoenixDriver");
+ } catch (ClassNotFoundException e) {
+ LOG.warn(e.getStackTrace());
+ }{code}
Is there a reason we wouldn't want to propagate this as a RuntimeException?
{code:java}
- <hbase.version>2.0.0</hbase.version>
+ <hbase.version>2.0.0-beta-2</hbase.version>{code}
I think Phoenix is relying on changes made since 2.0.0-beta-2 which would cause
a breakage. Maybe not?
{code:java}
- <hive.version>1.2.1</hive.version>
+ <hive.version>3.0.0-SNAPSHOT</hive.version>{code}
We need to watch for this and switch over to the 3.0.0 release. Looks like
there are only 7 Jira issues remaining in the fixVersion. I think they're close.
{code:java}
- <avatica.version>1.10.0</avatica.version>
+ <avatica.version>1.11.0</avatica.version>{code}
Unrelated ;), but I don't think it will be harmful.
Let me run these locally, but I think it looks good!
> Phoenix-hive compilation broken on >=Hive 2.3
> ---------------------------------------------
>
> Key: PHOENIX-4423
> URL: https://issues.apache.org/jira/browse/PHOENIX-4423
> Project: Phoenix
> Issue Type: Bug
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Critical
> Fix For: 5.0.0
>
> Attachments: PHOENIX-4423.002.patch, PHOENIX-4423_v1.patch,
> PHOENIX-4423_v2.patch, PHOENIX-4423_wip1.patch, PHOENIX-4423_wip2.patch
>
>
> HIVE-15167 removed an interface which we're using in Phoenix which obviously
> fails compilation. Will need to figure out how to work with Hive 1.x, <2.3.0,
> and >=2.3.0.
> FYI [~sergey.soldatov]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
