Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/298#discussion_r183133702
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/QueryCompiler.java ---
@@ -383,7 +384,7 @@ protected QueryPlan
compileJoinQuery(JoinCompiler.Strategy strategy, StatementCo
new PTable[]{lhsTable}, new int[]{fieldPosition},
postJoinFilterExpression, QueryUtil.getOffsetLimit(limit, offset));
Pair<Expression, Expression> keyRangeExpressions = new
Pair<Expression, Expression>(null, null);
getKeyExpressionCombinations(keyRangeExpressions, context,
joinTable.getStatement(), rhsTableRef, type, joinExpressions, hashExpressions);
- return HashJoinPlan.create(joinTable.getStatement(),
rhsPlan, joinInfo, new HashSubPlan[]{new HashSubPlan(0, lhsPlan,
hashExpressions, false, keyRangeExpressions.getFirst(),
keyRangeExpressions.getSecond())});
+ return HashJoinPlan.create(joinTable.getStatement(),
rhsPlan, joinInfo, new HashSubPlan[]{new HashSubPlan(0, lhsPlan,
hashExpressions, false, false, keyRangeExpressions.getFirst(),
keyRangeExpressions.getSecond())});
--- End diff --
This is also hash-join but with left table as build side. I think we should
be able to use persistent cache as well. And could you also add another test to
cover this point?
---
