[ https://issues.apache.org/jira/browse/PHOENIX-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460202#comment-16460202 ]
Hudson commented on PHOENIX-4718: --------------------------------- FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-1.3 #112 (See [https://builds.apache.org/job/Phoenix-4.x-HBase-1.3/112/]) PHOENIX-4718 Decrease overhead of tracking aggregate heap size (jtaylor: rev dec9f2897a62709d0b9b73670ea73c8438997b03) * (edit) phoenix-core/src/main/java/org/apache/phoenix/expression/aggregator/BaseAggregator.java * (edit) phoenix-core/src/test/java/org/apache/phoenix/query/QueryServicesTestImpl.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/expression/aggregator/DistinctValueWithCountServerAggregator.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/expression/aggregator/ClientAggregators.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/SpillableGroupByIT.java * (add) phoenix-core/src/main/java/org/apache/phoenix/expression/aggregator/NonSizeTrackingServerAggregators.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/expression/aggregator/ServerAggregators.java * (edit) phoenix-core/src/test/java/org/apache/phoenix/compile/QueryCompilerTest.java * (add) phoenix-core/src/main/java/org/apache/phoenix/expression/aggregator/SizeTrackingServerAggregators.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/execute/ClientAggregatePlan.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/expression/aggregator/Aggregators.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/expression/aggregator/Aggregator.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/query/QueryServices.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java > Decrease overhead of tracking aggregate heap size > ------------------------------------------------- > > Key: PHOENIX-4718 > URL: https://issues.apache.org/jira/browse/PHOENIX-4718 > Project: Phoenix > Issue Type: Bug > Reporter: James Taylor > Assignee: James Taylor > Priority: Major > Fix For: 4.14.0, 5.0.0 > > Attachments: PHOENIX-4718-4.x-HBase-0.98.patch, PHOENIX-4718.patch, > PHOENIX-4718_v2.patch, PHOENIX-4718_v3.patch > > > Since PHOENIX-4148, we track the heap size while aggregation is occurring. > This decreased performance of aggregation by ~20%. We really only need to > track this for the DistinctValueWithCountServerAggregator (used by DISTINCT > COUNT, DISTINCT, PERCENTILE functions, and STDDEV functions). By > conditionally tracking, we should be able to bring perf back to what it was > before. -- This message was sent by Atlassian JIRA (v7.6.3#76005)