[ 
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471218#comment-16471218
 ] 

Andrew Purtell commented on PHOENIX-3655:
-----------------------------------------

> we can expose them via a servlet just like how hbase-server does it at 
> {{/jmx}} path, which as far as I understand, uses a JMX client internally to 
> read all the metrics and display it the corresponding format. 
> {{JMXJsonServlet}} handles that portion. We can expose a similar one at PQS 
> level.

+1 to this approach for an initial version

Someone monitoring an HBase server fleet is probably going to be scraping JMX 
metrics from the JMX servlets already. (Not sure how widespread other Hadoop 
metrics integrations are used. Anyone have any insight there?) Doing this for 
PQS also fits in naturally. Adequate for initial deliverable?

Integration via hbase-metrics-api gives some flexibility for more options down 
the road.

> Metrics for PQS
> ---------------
>
>                 Key: PHOENIX-3655
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3655
>             Project: Phoenix
>          Issue Type: New Feature
>    Affects Versions: 4.8.0
>         Environment: Linux 3.13.0-107-generic kernel, v4.9.0-HBase-0.98
>            Reporter: Rahul Shrivastava
>            Assignee: Karan Mehta
>            Priority: Major
>             Fix For: 4.15.0
>
>         Attachments: MetricsforPhoenixQueryServerPQS.pdf
>
>   Original Estimate: 240h
>  Remaining Estimate: 240h
>
> Phoenix Query Server runs a separate process compared to its thin client. 
> Metrics collection is currently done by PhoenixRuntime.java i.e. at Phoenix 
> driver level. We need the following
> 1. For every jdbc statement/prepared statement/ run by PQS , we need 
> capability to collect metrics at PQS level and push the data to external sink 
> i.e. file, JMX , other external custom sources. 
> 2. Besides this global metrics could be periodically collected and pushed to 
> the sink. 
> 2. PQS can be configured to turn on metrics collection and type of collect ( 
> runtime or global) via hbase-site.xml
> 3. Sink could be configured via an interface in hbase-site.xml. 
> All metrics definition https://phoenix.apache.org/metrics.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to