Github user ortutay commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/298#discussion_r188783472
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/compile/QueryCompiler.java ---
    @@ -383,7 +384,7 @@ protected QueryPlan 
compileJoinQuery(JoinCompiler.Strategy strategy, StatementCo
                             new PTable[]{lhsTable}, new int[]{fieldPosition}, 
postJoinFilterExpression, QueryUtil.getOffsetLimit(limit, offset));
                     Pair<Expression, Expression> keyRangeExpressions = new 
Pair<Expression, Expression>(null, null);
                     getKeyExpressionCombinations(keyRangeExpressions, context, 
joinTable.getStatement(), rhsTableRef, type, joinExpressions, hashExpressions);
    -                return HashJoinPlan.create(joinTable.getStatement(), 
rhsPlan, joinInfo, new HashSubPlan[]{new HashSubPlan(0, lhsPlan, 
hashExpressions, false, keyRangeExpressions.getFirst(), 
keyRangeExpressions.getSecond())});
    +                return HashJoinPlan.create(joinTable.getStatement(), 
rhsPlan, joinInfo, new HashSubPlan[]{new HashSubPlan(0, lhsPlan, 
hashExpressions, false, false, keyRangeExpressions.getFirst(), 
keyRangeExpressions.getSecond())});
    --- End diff --
    
    @maryannxue I've changed the code here to use the `usePersistentCache` 
flag, but I'm not sure how to force a `HASH_BUILD_LEFT` strategy. The test I've 
put in the integration test file does not actually use that strategy. Do you 
know of an easy way to force a left table hash join?


---

Reply via email to