Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/301#discussion_r190381688
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java ---
@@ -549,7 +549,7 @@ public MutationPlan compile(UpsertStatement upsert)
throws SQLException {
select = SelectStatement.create(select, hint);
// Pass scan through if same table in upsert and select so
that projection is computed correctly
// Use optimizer to choose the best plan
- QueryCompiler compiler = new QueryCompiler(statement, select,
selectResolver, targetColumns, parallelIteratorFactoryToBe, new
SequenceManager(statement), false, false, null);
+ QueryCompiler compiler = new QueryCompiler(statement, select,
selectResolver, targetColumns, parallelIteratorFactoryToBe, new
SequenceManager(statement), true, false, null);
--- End diff --
This seems like too general of a change for the specific issue you're
trying to fix for ARRAY_APPEND. I'm also not sure *why* it would impact it.
Can't you make changes to ArrayAppendFunction or it's base class to get the
desired affect?
Any opinions, @maryannxue. Do you remember when/why we need this
projectTuples boolean for QueryCompiler?
---
