Github user gjacoby126 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r197821955
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/replication/SystemCatalogWALEntryFilter.java
---
@@ -35,20 +35,18 @@
* during cluster upgrades. However, tenant-owned data such as
tenant-owned views need to
* be copied. This WALEntryFilter will only allow tenant-owned rows in
SYSTEM.CATALOG to
* be replicated. Data from all other tables is automatically passed. It
will also copy
- * child links in SYSTEM.CATALOG that are globally-owned but point to
tenant-owned views.
+ * child links in SYSTEM.CHILD_LINK that are globally-owned but point to
tenant-owned views.
*
*/
public class SystemCatalogWALEntryFilter implements WALEntryFilter {
- private static byte[] CHILD_TABLE_BYTES =
- new byte[]{PTable.LinkType.CHILD_TABLE.getSerializedValue()};
-
@Override
public WAL.Entry filter(WAL.Entry entry) {
- //if the WAL.Entry's table isn't System.Catalog, it auto-passes this
filter
+ //if the WAL.Entry's table isn't System.Catalog or System.Child_Link,
it auto-passes this filter
//TODO: when Phoenix drops support for pre-1.3 versions of HBase, redo
as a WALCellFilter
- if (!SchemaUtil.isMetaTable(entry.getKey().getTablename().getName())){
+ byte[] tableName = entry.getKey().getTablename().getName();
+ if (!SchemaUtil.isMetaTable(tableName) &&
!SchemaUtil.isChildLinkTable(tableName)){
--- End diff --
Would it be safe to turn on normal HBase replication on the new
System.CHILD_LINK? (That is, is there any unwanted data in System.CHILD_LINK
that this WALFilter wouldn't copy that normal HBase replication would?)
If normal HBase replication works for System.CHILD_LINK, and all view data
left in System.Catalog starts with tenant_id, then the logic here can be
greatly simplified, similar to how it was before PHOENIX-4229
---
