[GitHub] phoenix pull request #315: PHOENIX-3655 Global Phoenix Client Metrics for PQ...

[joshelser]

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/315#discussion_r206598488
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java ---
    @@ -204,6 +230,45 @@ private static void resetGlobalMetrics() {
             }
         }
     
    +    // Phoenix Client Metrics are transported via Hadoop-metrics2 sink
    +    // The test sink is defined at GlobalPhoenixMetricsTestSink
    +    // Configuration for Hadoop-metrics2 comes from 
hadoop-metrics2.properties file located in test/resources
    --- End diff --
    
    Nice!


---