[ https://issues.apache.org/jira/browse/PHOENIX-5228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Monani Mihir updated PHOENIX-5228: ---------------------------------- Description: It would be good to use slf4j for logging in phoenix project. Here is list of files where doesn't use slf4j. phoenix-core :- {noformat} WALRecoveryRegionPostOpenIT.java WALReplayWithIndexWritesAndCompressedWALIT.java BasePermissionsIT.java ChangePermissionsIT.java IndexRebuildIncrementDisableCountIT.java InvalidIndexStateClientSideIT.java MutableIndexReplicationIT.java FailForUnsupportedHBaseVersionsIT.java SecureUserConnectionsIT.java PhoenixMetricsIT.java BaseTracingTestIT.java PhoenixTracingEndToEndIT.java PhoenixRpcSchedulerFactory.java IndexHalfStoreFileReaderGenerator.java BinaryCompatibleBaseDecoder.java ServerCacheClient.java CallRunner.java MetaDataRegionObserver.java PhoenixAccessController.java PhoenixAccessController.java ScanRegionObserver.java TaskRegionObserver.java DropChildViewsTask.java IndexRebuildTask.java BaseQueryPlan.java HashJoinPlan.java CollationKeyFunction.java Indexer.java LockManager.java BaseIndexBuilder.java IndexBuildManager.java NonTxIndexBuilder.java IndexMemStore.java BaseTaskRunner.java QuickFailingTaskRunner.java TaskBatch.java ThreadPoolBuilder.java ThreadPoolManager.java IndexManagementUtil.java IndexWriter.java IndexWriterUtils.java KillServerOnFailurePolicy.java ParallelWriterIndexCommitter.java RecoveryIndexWriter.java TrackingParallelWriterIndexCommitter.java PhoenixIndexFailurePolicy.java PhoenixTransactionalIndexer.java SnapshotScanner.java PhoenixEmbeddedDriver.java PhoenixResultSet.java QueryLogger.java QueryLoggerDisruptor.java TableLogWriter.java PhoenixInputFormat.java PhoenixOutputFormat.java PhoenixRecordReader.java PhoenixRecordWriter.java PhoenixServerBuildIndexInputFormat.java PhoenixMRJobSubmitter.java PhoenixConfigurationUtil.java Metrics.java DefaultStatisticsCollector.java StatisticsScanner.java PhoenixMetricsSink.java TraceReader.java TraceSpanReceiver.java TraceWriter.java Tracing.java EquiDepthStreamHistogram.java PhoenixMRJobUtil.java QueryUtil.java ServerUtil.java ZKBasedMasterElectionUtil.java IndexTestingUtils.java StubAbortable.java TestIndexWriter.java TestParalleIndexWriter.java TestParalleWriterIndexCommitter.java TestWALRecoveryCaching.java LoggingSink.java ParameterizedPhoenixCanaryToolIT.java CoprocessorHConnectionTableFactoryTest.java TestUtil.java{noformat} phoenix-tracing-webapp :- {noformat} org/apache/phoenix/tracingwebapp/http/Main.java {noformat} was: It would be good to change slf4j to apache log4j. Here is list of files where we use slf4j instead of apache log4j. phoenix-core :- {noformat} BaseTest.java UpsertSelectOverlappingBatchesIT.java ConnectionQueryServicesTestImpl.java PartialScannerResultsDisabledIT.java End2EndTestDriver.java BaseQueryIT.java TableSnapshotReadsMapReduceIT.java OrphanViewToolIT.java PartialIndexRebuilderIT.java Sandbox.java ConnectionCachingIT.java ScanPlan.java AggregatePlan.java MutationState.java FirstLastValueServerAggregator.java SizeTrackingServerAggregators.java LikeExpression.java PhoenixCanaryTool.java RowKeyComparisonFilter.java UpdateStatisticsTool.java MetaDataClient.java SpillFile.java SpillableGroupByCache.java TenantCacheImpl.java GlobalCache.java GlobalMemoryManager.java FromCompiler.java PhoenixDriver.java PhoenixStatement.java PhoenixEmbeddedDriver.java FormatToBytesWritableMapper.java FormatToKeyValueReducer.java PhoenixTextInputFormat.java OrphanViewTool.java MultiHfileOutputFormat.java PhoenixIndexPartialBuildMapper.java IndexScrutinyMapper.java IndexScrutinyTool.java PhoenixServerBuildIndexMapper.java PhoenixIndexImportDirectReducer.java IndexTool.java PhoenixIndexImportMapper.java DirectHTableWriter.java PhoenixIndexImportDirectMapper.java IndexToolUtil.java RegexToKeyValueMapper.java AbstractBulkLoadTool.java GlobalClientMetrics.java ReadOnlyProps.java CSVCommonsLoader.java CsvUpsertExecutor.java JsonUpsertExecutor.java RegexUpsertExecutor.java UpsertExecutor.java UpgradeUtil.java MetaDataUtil.java Closeables.java GuidePostsCache.java PhoenixStatsCacheLoader.java ConnectionQueryServicesImpl.java GroupedAggregateRegionObserver.java MetaDataEndpointImpl.java UngroupedAggregateRegionObserver.java OmidTransactionContext.java TephraTransactionContext.java ChunkedResultIterator.java ParallelIterators.java RoundRobinResultIterator.java BaseResultIterators.java TableResultIterator.java{noformat} phoenix-pherf :- {noformat} XMLResultHandlerTest.java ConfigurationParserTest.java XMLConfigParserTest.java RulesApplier.java SchemaReader.java ResultManager.java XMLConfigParser.java Pherf.java ResourceList.java PhoenixUtil.java WriteWorkload.java QueryVerifier.java MultiThreadedRunner.java WorkloadExecutor.java QueryExecutor.java MultithreadedDiffer.java {noformat} > use slf4j for logging in phoenix project > ---------------------------------------- > > Key: PHOENIX-5228 > URL: https://issues.apache.org/jira/browse/PHOENIX-5228 > Project: Phoenix > Issue Type: Improvement > Affects Versions: 4.14.1, 5.1.0 > Reporter: Monani Mihir > Priority: Trivial > > It would be good to use slf4j for logging in phoenix project. Here is list of > files where doesn't use slf4j. > phoenix-core :- > {noformat} > WALRecoveryRegionPostOpenIT.java > WALReplayWithIndexWritesAndCompressedWALIT.java > BasePermissionsIT.java > ChangePermissionsIT.java > IndexRebuildIncrementDisableCountIT.java > InvalidIndexStateClientSideIT.java > MutableIndexReplicationIT.java > FailForUnsupportedHBaseVersionsIT.java > SecureUserConnectionsIT.java > PhoenixMetricsIT.java > BaseTracingTestIT.java > PhoenixTracingEndToEndIT.java > PhoenixRpcSchedulerFactory.java > IndexHalfStoreFileReaderGenerator.java > BinaryCompatibleBaseDecoder.java > ServerCacheClient.java > CallRunner.java > MetaDataRegionObserver.java > PhoenixAccessController.java > PhoenixAccessController.java > ScanRegionObserver.java > TaskRegionObserver.java > DropChildViewsTask.java > IndexRebuildTask.java > BaseQueryPlan.java > HashJoinPlan.java > CollationKeyFunction.java > Indexer.java > LockManager.java > BaseIndexBuilder.java > IndexBuildManager.java > NonTxIndexBuilder.java > IndexMemStore.java > BaseTaskRunner.java > QuickFailingTaskRunner.java > TaskBatch.java > ThreadPoolBuilder.java > ThreadPoolManager.java > IndexManagementUtil.java > IndexWriter.java > IndexWriterUtils.java > KillServerOnFailurePolicy.java > ParallelWriterIndexCommitter.java > RecoveryIndexWriter.java > TrackingParallelWriterIndexCommitter.java > PhoenixIndexFailurePolicy.java > PhoenixTransactionalIndexer.java > SnapshotScanner.java > PhoenixEmbeddedDriver.java > PhoenixResultSet.java > QueryLogger.java > QueryLoggerDisruptor.java > TableLogWriter.java > PhoenixInputFormat.java > PhoenixOutputFormat.java > PhoenixRecordReader.java > PhoenixRecordWriter.java > PhoenixServerBuildIndexInputFormat.java > PhoenixMRJobSubmitter.java > PhoenixConfigurationUtil.java > Metrics.java > DefaultStatisticsCollector.java > StatisticsScanner.java > PhoenixMetricsSink.java > TraceReader.java > TraceSpanReceiver.java > TraceWriter.java > Tracing.java > EquiDepthStreamHistogram.java > PhoenixMRJobUtil.java > QueryUtil.java > ServerUtil.java > ZKBasedMasterElectionUtil.java > IndexTestingUtils.java > StubAbortable.java > TestIndexWriter.java > TestParalleIndexWriter.java > TestParalleWriterIndexCommitter.java > TestWALRecoveryCaching.java > LoggingSink.java > ParameterizedPhoenixCanaryToolIT.java > CoprocessorHConnectionTableFactoryTest.java > TestUtil.java{noformat} > phoenix-tracing-webapp :- > {noformat} > org/apache/phoenix/tracingwebapp/http/Main.java > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)