[ 
https://issues.apache.org/jira/browse/PHOENIX-5455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swaroopa Kadam updated PHOENIX-5455:
------------------------------------
    Comment: was deleted

(was: /home/jenkins/tools/jiracli/latest/jira.sh -s 
[https://issues.apache.org/jira]
 -a addcomment -u hadoopqa -p 4hadoopqa --comment '\{color:red}-1 
overall\{color}.  Here are the results of testing the latest attachment   
[http://issues.apache.org/jira/secure/attachment/12978921/PHOENIX-5455.4.x-HBase-1.5.v1.patch]
  against 4.x-HBase-1.5 branch at commit 
197b6e30c894b657758c5d0cb3c6182d6c8d4723.
  ATTACHMENT ID: 12978921

    \{color:green}+1 @author\{color}.  The patch does not contain any @author 
tags.

    \{color:green}+1 tests included\{color}.  The patch appears to include 6 
new or modified tests.

    \{color:green}+1 javac\{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    \{color:red}-1 release audit\{color}.  The applied patch generated 3 
release audit warnings (more than the master'\''s current 0 warnings).

    \{color:green}+1 lineLengths\{color}.  The patch does not introduce lines 
longer than 100

    \{color:green}+1 core tests\{color}.  The patch passed unit tests in .

Test results: 
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/2932//testReport/]
Release audit warnings: 
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/2932//artifact/patchprocess/patchReleaseAuditWarnings.txt]
Console output: 
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/2932//console])

> IndexedKeyValue creation fails after HBASE-22034
> ------------------------------------------------
>
>                 Key: PHOENIX-5455
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5455
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.15.0, 4.14.3
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>            Priority: Blocker
>             Fix For: 4.15.0
>
>         Attachments: PHOENIX-5455-4.14-HBase-1.5.patch, 
> PHOENIX-5455-4.x-HBase-1.5.patch, PHOENIX-5455.4.x-HBase-1.5.v1.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> HBASE-22034 backported to branch-1 HBASE-21401 (adding several validation 
> checks to KeyValue creation) and HBASE-22032 (adding a null check for the row 
> key to KeyValue creation). It will first be released in HBase 1.5.
> In Phoenix 4.14.2 we included PHOENIX-5188, which adds logic to initialize 
> IndexedKeyValues with the appropriate row key and offsets, so that it can 
> pass the new check in HBASE-22032. However, it did not correctly handle all 
> the checks in HBASE-21401.
> When testing 4.14.3 of Phoenix with an HBase version containing HBASE-22034, 
> we see lots of errors like the following:
> java.lang.IllegalArgumentException: Overflow when reading key length at 
> position=0, KeyValueBytesHex=foo, offset=0, length=3
> This will affect the future 4.15-HBase-1.5, and as well as any future release 
> of a 4.14.3 based on HBase-1.5



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to