After some more discussions on PHOENIX-5584, it’s confirmed that there is definitely a backwards compatibility problem. I will spin up an RC2 after we resolve the issue.
Thanks, Chinmay On Mon, Nov 25, 2019 at 7:03 AM Josh Elser <[email protected]> wrote: > (sorry for piling on the vote thread) > > I would think that allowing rollback should be the _default_ case, > especially when we know that there is an incompatibility. > > On 11/23/19 11:27 AM, Chinmay Kulkarni wrote: > > Copying my comment from PHOENIX-5584: > > > > "On second thought, I actually think this is by design due to the change > > introduced by PHOENIX-4893 and PHOENIX-4765 since we only continue > writing > > the parent table column metadata while creating a view in case > > "phoenix.allow.system.catalog.rollback" is true. If this config is false > > (which is the default case), this is not done. > > I have verified that when the above config is true, this issue does not > > exist and old clients are able to query the view properly." > > > > Seems like this may not be an issue after all. Thomas, what do you think? > > > > > > On Fri, Nov 22, 2019 at 4:51 PM Geoffrey Jacoby <[email protected]> > wrote: > > > >> Great find, Xinyi, thanks for testing! > >> > >> Geoffrey > >> > >> On Fri, Nov 22, 2019 at 4:39 PM Chinmay Kulkarni < > >> [email protected]> > >> wrote: > >> > >>> I change my vote to -1 (binding). The issue that Xinyi pointed out is a > >>> backwards compatibility blocker. > >>> Also, I do not see the same bug with a 4.14 client and 4.13 client, > which > >>> means this seems to have been introduced in the 4.15 code. > >>> I will get PHOENIX-5584 fixed and spin up a new RC. Thanks for finding > >> this > >>> bug Xinyi! > >>> > >>> On Fri, Nov 22, 2019 at 4:21 PM xinyi yan <[email protected]> wrote: > >>> > >>>> -1 > >>>> > >>>> I found a bug that older client can't get right view metadata from > 4.15 > >>>> server when 4.15 client created a table and view. I also created JIRA > >>>> https://issues.apache.org/jira/browse/PHOENIX-5584 for this. In > short, > >>> you > >>>> can reproduce the bug as following: > >>>> > >>>> 1. start the sandbox at 4.15. > >>>> > >>>> 2. created table and view at 4.15 client. > >>>> 3. query `SELECT * FROM VIEW` at 4.14 client. > >>>> > >>>> > >>>> Thanks, > >>>> Xinyi Yan > >>>> > >>>> On Fri, Nov 22, 2019 at 11:52 AM Neha Gupta <[email protected]> > >>> wrote: > >>>> > >>>>> +1 (Non-Binding) > >>>>> - Built from source (4.15.0-HBase-1.3) > >>>>> - verified all IT tests > >>>>> - Did some basic DDL, upserts, deletes, querying, and everything > >> looks > >>>>> good. > >>>>> - Added some index and views, Upserts to view, querying and > >> everything > >>>>> looks good. > >>>>> > >>>>> On Thu, Nov 21, 2019 at 1:44 PM Vincent Poon <[email protected] > >>> > >>>>> wrote: > >>>>> > >>>>>> +1 (Binding) > >>>>>> > >>>>>> Did some sanity testing with old client and new server. Creating > >>>> tables, > >>>>>> global/local indexes, etc. all seemed fine. > >>>>>> > >>>>>> On Thu, Nov 21, 2019 at 12:58 PM [email protected] < > >> [email protected]> > >>>>>> wrote: > >>>>>> > >>>>>>> I agree that PHOENIX-5529 and PHOENIX-5580 are longstanding > >> issues > >>>> and > >>>>>>> not blockers for 4.15.0. My +1 stands. > >>>>>>> Other PCMs, please vote so that we can (finally) get a 4.15.0 > >>> release > >>>>>> out. > >>>>>>> Cheers. > >>>>>>> -- Lars > >>>>>>> > >>>>>>> On Wednesday, November 20, 2019, 7:23:01 PM PST, Chinmay > >>>> Kulkarni < > >>>>>>> [email protected]> wrote: > >>>>>>> > >>>>>>> +1 (Binding) > >>>>>>> > >>>>>>> - Built from source (4.15.0-HBase-1.3) : OK > >>>>>>> - mvn verify : OK > >>>>>>> - Did some basic DDL, upserts, deletes, querying, and everything > >>>> looked > >>>>>>> fine : OK > >>>>>>> (Note, I found PHOENIX-5529 > >>>>>>> <https://issues.apache.org/jira/browse/PHOENIX-5529> and > >>>> PHOENIX-5580 > >>>>>>> <https://issues.apache.org/jira/browse/PHOENIX-5580> during my > >>>>> testing, > >>>>>>> but > >>>>>>> these bugs are also present in 4.14.x and hence not blockers for > >>>>> 4.15.0) > >>>>>>> - Verified checksums : OK > >>>>>>> - Verified signatures : OK > >>>>>>> - mvn clean apache-rat:check : OK > >>>>>>> > >>>>>>> On Wed, Nov 20, 2019 at 10:34 AM Chinmay Kulkarni < > >>>>>>> [email protected]> wrote: > >>>>>>> > >>>>>>>> *REMINDER - [VOTE] Release of Apache Phoenix 4.15.0 RC1* > >>>>>>>> > >>>>>>>> Just sending out a friendly reminder to everyone to please vote > >>> on > >>>>>> Apache > >>>>>>>> Phoenix 4.15.0 RC1 (thanks Lars). > >>>>>>>> > >>>>>>>> On Tue, Nov 19, 2019 at 2:49 PM [email protected] < > >>> [email protected] > >>>>> > >>>>>>> wrote: > >>>>>>>> > >>>>>>>>> I responded yesterday, but somehow didn't appear to go > >> through. > >>>>>> Trying > >>>>>>>>> again... > >>>>>>>>> > >>>>>>>>> +1 (Binding) > >>>>>>>>> > >>>>>>>>> - built from source (4.x-HBase-1.5) with latest branch-1 HBase > >>>> (also > >>>>>>>>> built from source) > >>>>>>>>> - loaded a few million rows > >>>>>>>>> - tried with local indexes > >>>>>>>>> - issued upserts and deletes while splitting in HBase. > >>>>>>>>> - checked the test suite on Jenkins :) > >>>>>>>>> - all good > >>>>>>>>> - nothing undue in the logs > >>>>>>>>> > >>>>>>>>> -- Lars > >>>>>>>>> > >>>>>>>>> On Monday, November 18, 2019, 02:57:59 PM PST, Chinmay > >>>> Kulkarni < > >>>>>>>>> [email protected]> wrote: > >>>>>>>>> > >>>>>>>>> Hello Everyone, > >>>>>>>>> > >>>>>>>>> This is a call for a vote on Apache Phoenix 4.15.0 RC1. This > >> is > >>>> the > >>>>>> next > >>>>>>>>> minor release of Phoenix 4, compatible with Apache HBase 1.3, > >>>> 1.4, & > >>>>>>>>> 1.5. The release includes both a source-only release and a > >>>>> convenience > >>>>>>>>> binary release for each supported HBase version. > >>>>>>>>> > >>>>>>>>> This release has feature parity with supported HBase versions > >>> and > >>>>>>> includes > >>>>>>>>> the following improvements: > >>>>>>>>> - Support for multi-region SYSTEM.CATALOG > >>>>>>>>> - Omid integration with Phoenix > >>>>>>>>> - Orphan view tool > >>>>>>>>> - Separation of the Phoenix-Connectors and Phoenix-Queryserver > >>>>>> projects > >>>>>>>>> - 150+ bug fixes > >>>>>>>>> and much more > >>>>>>>>> > >>>>>>>>> The source tarball, including signatures, digests, etc can be > >>>> found > >>>>>> at: > >>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>>> > >>> > >> > https://dist.apache.org/repos/dist/dev/phoenix/apache-phoenix-4.15.0-HBase-1.3-rc1/src/ > >>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>>> > >>> > >> > https://dist.apache.org/repos/dist/dev/phoenix/apache-phoenix-4.15.0-HBase-1.4-rc1/src/ > >>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>>> > >>> > >> > https://dist.apache.org/repos/dist/dev/phoenix/apache-phoenix-4.15.0-HBase-1.5-rc1/src/ > >>>>>>>>> > >>>>>>>>> The binary artifacts can be found at: > >>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>>> > >>> > >> > https://dist.apache.org/repos/dist/dev/phoenix/apache-phoenix-4.15.0-HBase-1.3-rc1/bin/ > >>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>>> > >>> > >> > https://dist.apache.org/repos/dist/dev/phoenix/apache-phoenix-4.15.0-HBase-1.4-rc1/bin/ > >>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>>> > >>> > >> > https://dist.apache.org/repos/dist/dev/phoenix/apache-phoenix-4.15.0-HBase-1.5-rc1/bin/ > >>>>>>>>> > >>>>>>>>> For a complete list of changes, see: > >>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>>> > >>> > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315120&version=12343162 > >>>>>>>>> > >>>>>>>>> Artifacts are signed with my "CODE SIGNING KEY": > >>>>>>>>> 7C5FC713DE4C59D7 > >>>>>>>>> > >>>>>>>>> KEYS file available here: > >>>>>>>>> https://dist.apache.org/repos/dist/dev/phoenix/KEYS > >>>>>>>>> > >>>>>>>>> The hash and tag to be voted upon: > >>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>>> > >>> > >> > https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h=a9491b4339ceef1c09922c752147fd97068039cd > >>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>>> > >>> > >> > https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=tag;h=refs/tags/v4.15.0-HBase-1.3-rc1 > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>>> > >>> > >> > https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h=f95b1937af1a525c2bf49e0a50bf73fce09a5314 > >>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>>> > >>> > >> > https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=tag;h=refs/tags/v4.15.0-HBase-1.4-rc1 > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>>> > >>> > >> > https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h=241a3284cf9128a08d0db49d07c2cfecceeada06 > >>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>>> > >>> > >> > https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=tag;h=refs/tags/v4.15.0-HBase-1.5-rc1 > >>>>>>>>> > >>>>>>>>> Vote will be open for at least 72 hours. Please vote: > >>>>>>>>> > >>>>>>>>> [ ] +1 approve > >>>>>>>>> [ ] +0 no opinion > >>>>>>>>> [ ] -1 disapprove (and reason why) > >>>>>>>>> > >>>>>>>>> Thanks, > >>>>>>>>> The Apache Phoenix Team > >>>>>>>>> > >>>>>>>>> -- > >>>>>>>>> Chinmay Kulkarni > >>>>>>>>> > >>>>>>>> > >>>>>>>> -- > >>>>>>>> Chinmay Kulkarni > >>>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> -- > >>>>>>> Chinmay Kulkarni > >>>>>>> > >>>>>> > >>>>> > >>>> > >>> > >>> > >>> -- > >>> Chinmay Kulkarni > >>> > >> > > > > > -- Chinmay Kulkarni
