Hi! I've uploaded the patch to remove HBase 2.0 support to https://issues.apache.org/jira/browse/PHOENIX-5716 Please review!
On Sat, Jun 20, 2020 at 1:35 AM Guanghao Zhang <zghao...@gmail.com> wrote: > > > > HBase 2.2 , which is a stable 2.x release ? > > > Yes, the stable release pointer is 2.2.x now. See > http://hbase.apache.org/downloads.html > > Josh Elser <els...@apache.org> 于2020年6月20日周六 上午2:08写道： > > > I see no value in supporting 2.0. I have mixed feelings on 2.1. We > > should default to 2.2, especially with 2.3 releases incoming "soon". > > > > We're in a good position to help HBase drive adoption of certain > > versions. While this is always sort of "implicit" (it just happens), I > > see value in it via advertising what users should pick up. > > > > On 6/17/20 8:42 AM, cheng...@apache.org wrote: > > > > > > > > > > > > Should we only support HBase 2.2 , which is a stable 2.x release ? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > At 2020-06-17 16:04:58, "Istvan Toth" <st...@apache.org> wrote: > > >> The 4.x branch has historically deprecated unsupported branches. > > >> > > >> I'd be fine with removing support for EOL 2.x branches in master, > > >> https://issues.apache.org/jira/browse/PHOENIX-5716 is open for this > > very > > >> issue, > > >> but would welcome some community input before working on it. > > >> > > >> I also like Josh's idea, > > https://issues.apache.org/jira/browse/PHOENIX-5828 is > > >> quite similar to it. > > >> > > >> > > >> On Wed, Jun 17, 2020 at 2:49 AM Guanghao Zhang <zghao...@gmail.com> > > wrote: > > >> > > >>> HBase 2.0 and 2.1 has been EOL now. Does phoenix need to support > them? > > >>> > > >>> swaroopa kadam <swaroopa.kada...@gmail.com> 于2020年6月17日周三 上午12:32写道： > > >>> > > >>>> yes, that’s a good idea. > > >>>> > > >>>> On Tue, Jun 16, 2020 at 9:29 AM Josh Elser <els...@apache.org> > wrote: > > >>>> > > >>>>> Sounds like we should try to update precommit to at least compile > > >>>>> against _a version_ in each line 2.1/2.2/2.3 for master. Thoughts? > > >>>>> > > >>>>> On 6/16/20 11:57 AM, swaroopa kadam wrote: > > >>>>>> Thank you for the replies everyone! > > >>>>>> > > >>>>>> It puts me at ease by knowing the issue has been identified and > > being > > >>>>>> fixed. > > >>>>>> > > >>>>>> Thanks! > > >>>>>> > > >>>>>> On Tue, Jun 16, 2020 at 4:11 AM rajeshb...@apache.org < > > >>>>>> chrajeshbab...@gmail.com> wrote: > > >>>>>> > > >>>>>>> I am on the PHOENIX-5905 compilation issue and will fix it today. > > >>>>>>> > > >>>>>>> On Tue, Jun 16, 2020 at 3:07 PM cheng...@apache.org < > > >>>>> cheng...@apache.org> > > >>>>>>> wrote: > > >>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> PHOENIX-5905 caused the master branch compile broken, because > > >>>>>>>> > org.apache.hadoop.hbase.security.access.GetUserPermissionsRequest > > >>> is > > >>>>> only > > >>>>>>>> available in hbase 2.2.x, > > >>>>>>>> so when the hbase.profile=2.0 or hbase.profile=2.1, the > compiler > > >>>>> boken, > > >>>>>>>> Should we revert PHOENIX-5905 for the moment? > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> The error messages are : > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> [ERROR] COMPILATION ERROR : > > >>>>>>>> [INFO] > > >>> ------------------------------------------------------------- > > >>>>>>>> [ERROR] < > > >>>>>>>> > > >>>>>>> > > >>>>> > > >>>> > > >>> > > > https://builds.apache.org/job/Phoenix-master-matrix/HBASE_PROFILE=2.1/ws/phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java > > >>>>>>>> :[39,47] > > >>>>>>>> cannot find symbol > > >>>>>>>> symbol: class GetUserPermissionsRequest > > >>>>>>>> location: package org.apache.hadoop.hbase.security.access > > >>>>>>>> [ERROR] < > > >>>>>>>> > > >>>>>>> > > >>>>> > > >>>> > > >>> > > > https://builds.apache.org/job/Phoenix-master-matrix/HBASE_PROFILE=2.1/ws/phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java > > >>>>>>>> :[1452,48] > > >>>>>>>> cannot find symbol > > >>>>>>>> symbol: method hasUserName() > > >>>>>>>> location: variable request of type > > >>>>>>>> > > >>>>>>> > > >>>>> > > >>>> > > >>> > > > org.apache.hadoop.hbase.protobuf.generated.AccessControlProtos.GetUserPermissionsRequest > > >>>>>>>> [ERROR] < > > >>>>>>>> > > >>>>>>> > > >>>>> > > >>>> > > >>> > > > https://builds.apache.org/job/Phoenix-master-matrix/HBASE_PROFILE=2.1/ws/phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java > > >>>>>>>> :[1452,72] > > >>>>>>>> cannot find symbol > > >>>>>>>> symbol: method getUserName() > > >>>>>>>> location: variable request of type > > >>>>>>>> > > >>>>>>> > > >>>>> > > >>>> > > >>> > > > org.apache.hadoop.hbase.protobuf.generated.AccessControlProtos.GetUserPermissionsRequest > > >>>>>>>> [ERROR] < > > >>>>>>>> > > >>>>>>> > > >>>>> > > >>>> > > >>> > > > https://builds.apache.org/job/Phoenix-master-matrix/HBASE_PROFILE=2.1/ws/phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java > > >>>>>>>> :[1458,32] > > >>>>>>>> cannot find symbol > > >>>>>>>> symbol: method hasColumnFamily() > > >>>>>>>> location: variable request of type > > >>>>>>>> > > >>>>>>> > > >>>>> > > >>>> > > >>> > > > org.apache.hadoop.hbase.protobuf.generated.AccessControlProtos.GetUserPermissionsRequest > > >>>>>>>> [ERROR] < > > >>>>>>>> > > >>>>>>> > > >>>>> > > >>>> > > >>> > > > https://builds.apache.org/job/Phoenix-master-matrix/HBASE_PROFILE=2.1/ws/phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java > > >>>>>>>> :[1458,60] > > >>>>>>>> cannot find symbol > > >>>>>>>> symbol: method getColumnFamily() > > >>>>>>>> location: variable request of type > > >>>>>>>> > > >>>>>>> > > >>>>> > > >>>> > > >>> > > > org.apache.hadoop.hbase.protobuf.generated.AccessControlProtos.GetUserPermissionsRequest > > >>>>>>>> [ERROR] < > > >>>>>>>> > > >>>>>>> > > >>>>> > > >>>> > > >>> > > > https://builds.apache.org/job/Phoenix-master-matrix/HBASE_PROFILE=2.1/ws/phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java > > >>>>>>>> :[1460,32] > > >>>>>>>> cannot find symbol > > >>>>>>>> symbol: method hasColumnQualifier() > > >>>>>>>> location: variable request of type > > >>>>>>>> > > >>>>>>> > > >>>>> > > >>>> > > >>> > > > org.apache.hadoop.hbase.protobuf.generated.AccessControlProtos.GetUserPermissionsRequest > > >>>>>>>> [ERROR] < > > >>>>>>>> > > >>>>>>> > > >>>>> > > >>>> > > >>> > > > https://builds.apache.org/job/Phoenix-master-matrix/HBASE_PROFILE=2.1/ws/phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java > > >>>>>>>> :[1460,63] > > >>>>>>>> cannot find symbol > > >>>>>>>> symbol: method getColumnQualifier() > > >>>>>>>> location: variable request of type > > >>>>>>>> > > >>>>>>> > > >>>>> > > >>>> > > >>> > > > org.apache.hadoop.hbase.protobuf.generated.AccessControlProtos.GetUserPermissionsRequest > > >>>>>>>> [ERROR] < > > >>>>>>>> > > >>>>>>> > > >>>>> > > >>>> > > >>> > > > https://builds.apache.org/job/Phoenix-master-matrix/HBASE_PROFILE=2.1/ws/phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java > > >>>>>>>> :[1461,17] > > >>>>>>>> cannot find symbol > > >>>>>>>> symbol: class GetUserPermissionsRequest > > >>>>>>>> location: class > > >>>>>>>> > > org.apache.phoenix.end2end.BasePermissionsIT.CustomAccessController > > >>>>>>>> [ERROR] < > > >>>>>>>> > > >>>>>>> > > >>>>> > > >>>> > > >>> > > > https://builds.apache.org/job/Phoenix-master-matrix/HBASE_PROFILE=2.1/ws/phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java > > >>>>>>>> :[1463,49] > > >>>>>>>> cannot find symbol > > >>>>>>>> symbol: variable GetUserPermissionsRequest > > >>>>>>>> location: class > > >>>>>>>> > > org.apache.phoenix.end2end.BasePermissionsIT.CustomAccessController > > >>>>>>>> [ERROR] < > > >>>>>>>> > > >>>>>>> > > >>>>> > > >>>> > > >>> > > > https://builds.apache.org/job/Phoenix-master-matrix/HBASE_PROFILE=2.1/ws/phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java > > >>>>>>>> :[1467,29] > > >>>>>>>> cannot find symbol > > >>>>>>>> symbol: variable GetUserPermissionsRequest > > >>>>>>>> location: class > > >>> org.apache.phoenix.end2end.BasePermissionsIT.Custo > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> At 2020-06-16 14:26:23, "Istvan Toth" <st...@apache.org> wrote: > > >>>>>>>>> Hi! > > >>>>>>>>> > > >>>>>>>>> In some cases specifying non-default HBase and Hadoop versions > > can > > >>>>> cause > > >>>>>>>>> this. > > >>>>>>>>> Please report your full maven command line, and I'll look into > > it. > > >>>>>>>>> In the meantime you can disable the dependency check with -D > > >>>>>>>>> mdep.analyze.skip=true > > >>>>>>>>> > > >>>>>>>>> Istvan > > >>>>>>>>> > > >>>>>>>>> On Mon, Jun 15, 2020 at 7:57 PM swaroopa kadam < > > >>>>>>>> swaroopa.kada...@gmail.com> > > >>>>>>>>> wrote: > > >>>>>>>>> > > >>>>>>>>>> Thank you for the response, Andrew and Geoffrey. Below is the > > >>> error > > >>>>>>>> message > > >>>>>>>>>> I see: > > >>>>>>>>>> > > >>>>>>>>>> [ERROR] Failed to execute goal > > >>>>>>>>>> > > >>> org.apache.maven.plugins:maven-dependency-plugin:3.1.1:analyze-only > > >>>>>>>>>> (enforce-dependencies) on project phoenix-core: Dependency > > >>> problems > > >>>>>>>> found > > >>>>>>>>>> -> [Help 1] > > >>>>>>>>>> [ERROR] > > >>>>>>>>>> [ERROR] To see the full stack trace of the errors, re-run > Maven > > >>>> with > > >>>>>>>> the -e > > >>>>>>>>>> switch. > > >>>>>>>>>> [ERROR] Re-run Maven using the -X switch to enable full debug > > >>>>> logging. > > >>>>>>>>>> [ERROR] > > >>>>>>>>>> [ERROR] For more information about the errors and possible > > >>>> solutions, > > >>>>>>>>>> please read the following articles: > > >>>>>>>>>> [ERROR] [Help 1] > > >>>>>>>>>> > > >>>>>>> > > >>>> > > http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException > > >>>>>>>>>> [ERROR] > > >>>>>>>>>> [ERROR] After correcting the problems, you can resume the > build > > >>>> with > > >>>>>>> the > > >>>>>>>>>> command > > >>>>>>>>>> [ERROR] mvn <goals> -rf :phoenix-core > > >>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>>> On Mon, Jun 15, 2020 at 10:45 AM Geoffrey Jacoby > > >>>>>>>>>> <gjac...@salesforce.com.invalid> wrote: > > >>>>>>>>>> > > >>>>>>>>>>> git checkout master, then git pull, then mvn clean package > > >>>>>>> -DskipTests > > >>>>>>>>>>> passes for me, and I double-checked with git status that I > > don't > > >>>>>>> have > > >>>>>>>>>>> anything "extra" in my local environment. > > >>>>>>>>>>> > > >>>>>>>>>>> Geoffrey > > >>>>>>>>>>> > > >>>>>>>>>>> On Mon, Jun 15, 2020 at 10:29 AM Andrew Purtell < > > >>>>>>> apurt...@apache.org> > > >>>>>>>>>>> wrote: > > >>>>>>>>>>> > > >>>>>>>>>>>> Apache mailing list software stripps embedded images. Please > > >>> post > > >>>>>>>> text. > > >>>>>>>>>>>> > > >>>>>>>>>>>> > > >>>>>>>>>>>> On Mon, Jun 15, 2020 at 10:24 AM swaroopa kadam < > > >>>>>>>>>>>> swaroopa.kada...@gmail.com> > > >>>>>>>>>>>> wrote: > > >>>>>>>>>>>> > > >>>>>>>>>>>>> Hi, > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> I am trying to compile the master branch of phoenix and I > get > > >>>>>>> the > > >>>>>>>>>>>>> following error message. > > >>>>>>>>>>>>> What has changed recently? Do I need to make additional > > >>> changes? > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> Thanks. > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> [image: Screen Shot 2020-06-12 at 6.02.25 PM.png] > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> -- > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> Swaroopa Kadam > > >>>>>>>>>>>>> [image: https://]about.me/swaroopa_kadam > > >>>>>>>>>>>>> < > > >>>>>>>>>>>> > > >>>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>> > > >>>>>>> > > >>>>> > > >>>> > > >>> > > > https://about.me/swaroopa_kadam?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> > > >>>>>>>>>>>> > > >>>>>>>>>>>> > > >>>>>>>>>>>> -- > > >>>>>>>>>>>> Best regards, > > >>>>>>>>>>>> Andrew > > >>>>>>>>>>>> > > >>>>>>>>>>>> Words like orphans lost among the crosstalk, meaning torn > from > > >>>>>>>> truth's > > >>>>>>>>>>>> decrepit hands > > >>>>>>>>>>>> - A23, Crosstalk > > >>>>>>>>>>>> > > >>>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>>> -- > > >>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>>> Swaroopa Kadam > > >>>>>>>>>> [image: https://]about.me/swaroopa_kadam > > >>>>>>>>>> < > > >>>>>>>>>> > > >>>>>>>> > > >>>>>>> > > >>>>> > > >>>> > > >>> > > > https://about.me/swaroopa_kadam?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api > > >>>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>> > > >>>>>>> > > >>>>> > > >>>> -- > > >>>> > > >>>> > > >>>> Swaroopa Kadam > > >>>> [image: https://]about.me/swaroopa_kadam > > >>>> < > > >>>> > > >>> > > > https://about.me/swaroopa_kadam?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api > > >>>>> > > >>>> > > >>> > > > -- *István Tóth* | Staff Software Engineer st...@cloudera.com <https://www.cloudera.com> [image: Cloudera] <https://www.cloudera.com/> [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image: Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera on LinkedIn] <https://www.linkedin.com/company/cloudera> <https://www.cloudera.com/> ------------------------------
