[ https://issues.apache.org/jira/browse/PHOENIX-5984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chinmay Kulkarni updated PHOENIX-5984: -------------------------------------- Attachment: PHOENIX-5984-4.x-v2.patch > Query timeout counter is not updated in all timeouts cases > ---------------------------------------------------------- > > Key: PHOENIX-5984 > URL: https://issues.apache.org/jira/browse/PHOENIX-5984 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.15.0 > Reporter: Chinmay Kulkarni > Assignee: Chinmay Kulkarni > Priority: Major > Labels: metrics, phoenix-hardening, quality-improvement > Fix For: 4.16.0 > > Attachments: PHOENIX-5984-4.x-v1.patch, PHOENIX-5984-4.x-v2.patch > > Time Spent: 40m > Remaining Estimate: 0h > > The OverallQueryMetrics query timeout counter and global query timeout > counter are not updated if the query times out before getting the future > corresponding to the scan i.e. if it times out at [this point| > https://github.com/apache/phoenix/blob/dcc88af8acc2ba8df10d2e9d498ab3646fdf0a78/phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java#L1299-L1301]. > We only update relevant metrics if we catch a TimeoutException > [here|https://github.com/apache/phoenix/blob/dcc88af8acc2ba8df10d2e9d498ab3646fdf0a78/phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java#L1361] > if the future.get times out > [here|https://github.com/apache/phoenix/blob/dcc88af8acc2ba8df10d2e9d498ab3646fdf0a78/phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java#L1312]. > We should update the metrics in the first case as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)