[ https://issues.apache.org/jira/browse/PHOENIX-6159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xinyi Yan updated PHOENIX-6159: ------------------------------- Description: The ([MultiThreadedRunner|#L109])] writes the result to the file without check the writeRuntimeResults value. I'm not sure if anyone is using this [disableRuntimeResult param in Pherf.java|https://github.com/apache/phoenix/blob/master/phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java#L156], which is not presenting what it indicates. I prefer to fix the behavior and match the meaning of disableRuntimeResult. was: The ResultManager has a logic to check writeRuntimeResults and creates defaultHandler or minimalHandler([ResultManager|[https://github.com/apache/phoenix/blob/master/phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/ResultManager.java#L69])], but it doesn't represent the meaning of the writeRuntimeResults. If writeRuntimeResults is false, it should not add any ResultHandler for later use. The ([MultiThreadedRunner|[https://github.com/apache/phoenix/blob/master/phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultiThreadedRunner.java#L109])] writes the result to the file without check the writeRuntimeResults value. I'm not sure if anyone is using this [disableRuntimeResult param in Pherf.java|https://github.com/apache/phoenix/blob/master/phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java#L156], which is not presenting what it indicates. I prefer to fix the behavior and match the meaning of disableRuntimeResult. > Phoenix-pherf writes the result file even disableRuntimeResult flag is true > --------------------------------------------------------------------------- > > Key: PHOENIX-6159 > URL: https://issues.apache.org/jira/browse/PHOENIX-6159 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.15.0 > Reporter: Xinyi Yan > Priority: Major > Attachments: PHOENIX-6159.patch > > > The ([MultiThreadedRunner|#L109])] writes the result to the file without > check the writeRuntimeResults value. > I'm not sure if anyone is using this [disableRuntimeResult param in > Pherf.java|https://github.com/apache/phoenix/blob/master/phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java#L156], > which is not presenting what it indicates. I prefer to fix the behavior and > match the meaning of disableRuntimeResult. > > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)