I already reverted the patch from both branches earlier this afternoon. Sorry for the noise.
Geoffrey On Thu, Dec 10, 2020 at 2:44 PM Ankit Singhal <[email protected]> wrote: > Please free to revert from 4.x (and master) and re-open the corresponding > JIRA. > > On Thu, Dec 10, 2020 at 5:50 AM 程磊 <[email protected]> wrote: > > > > > > > > > Yes， when I revert the 4.x before PHOENIX-5140, the IndexExtendedIT and > > IndexScrutinyToolIT are sucess. > > but after applying PHOENIX-5140,both IndexExtendedIT and > > IndexScrutinyToolIT are always failed. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > At 2020-12-10 16:51:27, "Ankit Singhal" <[email protected]> > wrote: > > >Thanks Chenglei for bringing the failures to the notice. Have you > > confirmed > > >that reverting PHOENIX-5140 fixes the problem? if yes then I would > suggest > > >reverting the fix and re-open the JIRA to be worked upon separately for > > the > > >new fix. > > > > > >On Wed, Dec 9, 2020 at 7:14 PM [email protected] <[email protected] > > > > >wrote: > > > > > >> I noticed IndexExtendedIT always failed on 4.x and master now, It may > be > > >> caused by PHOENIX-5140 , for 4.x , the stack is : > > >> java.lang.AssertionError: expected:<0> but was:<-1> > > >> at org.junit.Assert.fail(Assert.java:89) > > >> at org.junit.Assert.failNotEquals(Assert.java:835) > > >> at org.junit.Assert.assertEquals(Assert.java:647) > > >> at org.junit.Assert.assertEquals(Assert.java:633) > > >> at > > >> > > org.apache.phoenix.end2end.IndexToolIT.runIndexTool(IndexToolIT.java:806) > > >> at > > >> > > org.apache.phoenix.end2end.IndexToolIT.runIndexTool(IndexToolIT.java:785) > > >> at > > >> > > org.apache.phoenix.end2end.IndexToolIT.runIndexTool(IndexToolIT.java:776) > > >> at > > >> > > org.apache.phoenix.end2end.IndexToolIT.runIndexTool(IndexToolIT.java:770) > > >> at > > >> > > org.apache.phoenix.end2end.IndexToolIT.runIndexTool(IndexToolIT.java:744) > > >> at > > >> > > > org.apache.phoenix.end2end.IndexExtendedIT.testMutableIndexWithUpdates(IndexExtendedIT.java:166) > > >> > > >> > > >> and the similar stack is on master， I suggest we should rollback or > stop > > >> commit to the repo until the problem is fixed. > > >
