-1 (Will change my vote if this turns out to be environmental on my machine)
Verified sig and checksums for source and the 2.4 binary tarball (will eventually verify all 4) apache-rat:check for licenses passes. Ran mvn clean install -DskipTests on the untarred source dir. Passed with JDK 8 When using the JDK 11 compiler, Maven build failed with a mvn dependency check on phoenix-pherf because it treated warnings as error: [*WARNING*] Used undeclared dependencies found: [*WARNING*] jakarta.xml.bind:jakarta.xml.bind-api:jar:2.3.2:test We don't officially support JDK 11 yet so this is OK. With JDK 8 ran "mvn clean verify -Dhbase.profile=2.4" . Build failed trying to create MetricTypeTest in phoenix-core -- seems to be a classpath error because I can see MetricTypeTest.class in the appropriate folder under phoenix-core/target/test-classes. Underlying exception when run with -e is a ClassNotFoundException for MetricTypeTest. *Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test failed: java.lang.RuntimeException: Unable to create test class 'org.apache.phoenix.metrics.MetricTypeTest'* When I force mvn verify to continue using -fn I get a test failure in phoenix-pherf. Looks like either a missing resource or a classpath issue: [*ERROR*] *Tests **run: 1*, Failures: 0, *Errors: 1*, Skipped: 0, Time elapsed: 0.416 s* <<< FAILURE!* - in org.apache.phoenix.pherf.result.impl. *XMLResultHandlerTest* [*ERROR*] testDTDInResults(org.apache.phoenix.pherf.result.impl.XMLResultHandlerTest) Time elapsed: 0.416 s <<< ERROR! com.ctc.wstx.exc.WstxIOException: [path of my base directory]/phoenix-5.1.0/phoenix-pherf/target/test-classes/malicious_results_with_dtd.xml (No such file or directory) Geoffrey On Tue, Feb 2, 2021 at 2:44 PM Istvan Toth <[email protected]> wrote: > Please vote on this Apache phoenix release candidate, > phoenix-5.1.0RC1 > > The VOTE will remain open for at least 72 hours. > > [ ] +1 Release this package as Apache phoenix 5.1.0 > [ ] -1 Do not release this package because ... > > The tag to be voted on is 5.1.0RC1: > > https://github.com/apache/phoenix/tree/5.1.0RC1 > > The release files, including signatures, digests, as well as CHANGES.md > and RELEASENOTES.md included in this RC can be found at: > > https://dist.apache.org/repos/dist/dev/phoenix/phoenix-5.1.0RC1/ > > Maven artifacts are available in a staging repository at: > > https://repository.apache.org/content/repositories// > > Artifacts were signed with the 0x794433C7 key which can be found in: > > https://dist.apache.org/repos/dist/release/phoenix/KEYS > > To learn more about Apache phoenix, please see > > http://phoenix.apache.org/ > > Thanks, > Istvan >
