+1 (binding) Signatures and checksums for src and all 3 bin tarballs - OK apache-rat:check: OK mvn clean install -DskipTests : OK mvn verify (2.4 profile) : All passed except about a dozen timeouts, all of which passed on a manual retry: OK Ran local cluster and sqlline, created a complex table, added some data, created an index, CRUD worked as expected when using both data table and index: OK
Geoffrey On Mon, Feb 8, 2021 at 3:18 PM Xinyi Yan <yanxi...@apache.org> wrote: > +1 (non-binding) > > Verified signatures and checksum. > Ran mvn clean install -DskipTests with no issues. > Tested locally with DDL(TABLE, VIEW, and INDEX), as well as upsert/deletion > queries. > > > Thanks, > Xinyi > > On Mon, Feb 8, 2021 at 2:55 PM Ankit Singhal <an...@apache.org> wrote: > > > +1(binding) > > > > * Download source and build - OK > > * Signatures and checksums for src and bin(2.4)- OK > > * apache-rat:check - SUCCESS > > * CHANGES and RELEASENOTES - OK > > * Unit tests (have not tested IT) - Ok > > > > Regards, > > Ankit Singhal > > > > > > On Mon, Feb 8, 2021 at 2:30 PM Chinmay Kulkarni < > > chinmayskulka...@gmail.com> > > wrote: > > > > > +1 (Binding) > > > Tested against HBase 2.4 > > > > > > * Build from source (mvn clean install -DskipTests): OK > > > * Did some basic DDL, queries, upserts, deletes and everything looked > > fine: > > > OK > > > * Verified checksums: OK > > > * Verified signatures: OK > > > * mvn clean apache-rat:check: OK > > > > > > On Sun, Feb 7, 2021 at 10:11 PM Viraj Jasani <vjas...@apache.org> > wrote: > > > > > > > +1 (non-binding) > > > > > > > > Tested against HBase-2.4 profile: > > > > > > > > * Signature: ok > > > > * Checksum : ok > > > > * Rat check (1.8.0_171): ok > > > > - mvn clean apache-rat:check > > > > * Built from source (1.8.0_171): ok > > > > - mvn clean install -DskipTests > > > > * Basic testing with mini cluster: ok > > > > * Unit tests pass (1.8.0_171): failed (passed eventually) > > > > - mvn clean package && mvn verify -Dskip.embedded > > > > > > > > > > > > [ERROR] Tests run: 14, Failures: 0, Errors: 1, Skipped: 0, Time > > elapsed: > > > > 768.631 s <<< FAILURE! - in > org.apache.phoenix.end2end.OrphanViewToolIT > > > > [ERROR] > > > > > > > > > > testDeleteChildViewRows[OrphanViewToolIT_multiTenant=true](org.apache.phoenix.end2end.OrphanViewToolIT) > > > > Time elapsed: 306.591 s <<< ERROR! > > > > java.sql.SQLTimeoutException: . Query couldn't be completed in the > > > > allotted time: 300000 ms > > > > at > > > > > > > > > > org.apache.phoenix.exception.SQLExceptionCode$16.newException(SQLExceptionCode.java:469) > > > > at > > > > > > > > > > org.apache.phoenix.exception.SQLExceptionInfo.buildException(SQLExceptionInfo.java:217) > > > > at > > > > > > > > > > org.apache.phoenix.iterate.BaseResultIterators.getIterators(BaseResultIterators.java:1390) > > > > > > > > > > > > [ERROR] Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time > > elapsed: > > > > 274.449 s <<< FAILURE! - in > > org.apache.phoenix.end2end.PermissionsCacheIT > > > > [ERROR] > > > > > > > > > > testAutomaticGrantWithIndexAndView(org.apache.phoenix.end2end.PermissionsCacheIT) > > > > Time elapsed: 56.42 s <<< FAILURE! > > > > java.lang.AssertionError: Expected exception was not thrown for user > > > > 'unprivilegedUser_N000027' > > > > at org.junit.Assert.fail(Assert.java:89) > > > > at > > > > > > > > > > org.apache.phoenix.end2end.BasePermissionsIT.verifyDenied(BasePermissionsIT.java:842) > > > > at > > > > > > > > > > org.apache.phoenix.end2end.BasePermissionsIT.verifyDenied(BasePermissionsIT.java:805) > > > > > > > > > > > > [ERROR] Tests run: 16, Failures: 0, Errors: 1, Skipped: 0, Time > > elapsed: > > > > 2,472.819 s <<< FAILURE! - in > > > > org.apache.phoenix.end2end.ParameterizedIndexUpgradeToolIT > > > > [ERROR] > > > > > > > > > > testDryRunAndFailures[IndexUpgradeToolIT_mutable=false,upgrade=true,isNamespaceEnabled=false, > > > > > > > > > > rebuild=false](org.apache.phoenix.end2end.ParameterizedIndexUpgradeToolIT) > > > > Time elapsed: 633.978 s <<< ERROR! > > > > org.apache.phoenix.exception.PhoenixIOException: > > > > java.util.concurrent.TimeoutException: The procedure 288 is still > > running > > > > at > > > > > > > > > > org.apache.phoenix.util.ServerUtil.parseServerException(ServerUtil.java:138) > > > > at > > > > > > > > > > org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureTableCreated(ConnectionQueryServicesImpl.java:1519) > > > > at > > > > > > > > > > org.apache.phoenix.query.ConnectionQueryServicesImpl.createTable(ConnectionQueryServicesImpl.java:1913) > > > > > > > > > > > > > > > > On 2021/02/05 10:28:25, Istvan Toth <st...@apache.org> wrote: > > > > > Please vote on this Apache phoenix release candidate, > > > > > phoenix-5.1.0RC4 > > > > > > > > > > The VOTE will remain open for at least 72 hours. > > > > > > > > > > [ ] +1 Release this package as Apache phoenix 5.1.0 > > > > > [ ] -1 Do not release this package because ... > > > > > > > > > > The tag to be voted on is 5.1.0RC4: > > > > > > > > > > https://github.com/apache/phoenix/tree/5.1.0RC4 > > > > > > > > > > The release files, including signatures, digests, as well as > > CHANGES.md > > > > > and RELEASENOTES.md included in this RC can be found at: > > > > > > > > > > https://dist.apache.org/repos/dist/dev/phoenix/phoenix-5.1.0RC4/ > > > > > > > > > > Maven artifacts are available in a staging repository at: > > > > > > > > > > https://repository.apache.org/#stagingRepositories > > > > (orgapachephoenix-1213) > > > > > > > > > > Artifacts were signed with 0x794433C7 key which can be found in: > > > > > > > > > > https://dist.apache.org/repos/dist/release/phoenix/KEYS > > > > > > > > > > To learn more about Apache phoenix, please see > > > > > > > > > > http://phoenix.apache.org/ > > > > > > > > > > Thanks, > > > > > Istvan > > > > > > > > > > > > > > > > > > -- > > > Chinmay Kulkarni > > > > > >
