+1 (non-binding) based on the signature, checksum and mvn clean install/verify.
On Sun, Feb 28, 2021 at 4:59 AM Viraj Jasani <vjas...@apache.org> wrote: > +1 (non-binding) > > Tested against HBase 2.4.1 (compiled with Hadoop profile 3.0) > > * Signature: ok > * Checksum : ok > * Rat check (1.8.0_171): ok > - mvn clean apache-rat:check > * Built from source (1.8.0_171): ok > - mvn clean install -DskipTests > * CRUD testing locally: ok > * Unit tests pass (1.8.0_171): failed > - mvn clean package && mvn verify -Dskip.embedded > > > [ERROR] Failures: > [ERROR] > IndexToolForNonTxGlobalIndexIT.testBuildSecondaryIndexAndScrutinize:421 > expected:<0> but was:<-1> > > [ERROR] Failures: > [ERROR] > > ViewTTLIT.testDeleteWithOnlyTenantView:1967->upsertDataAndRunValidations:2329->validateExpiredRowsAreNotReturnedUsingData:2390->verifyRowsBeforeTTLExpiration:2451 > Rows upserted and fetched do not match, upserted=5, fetched=4 > expected:<[00B0y0000000001, 00B0y0000000002, 00B0y0000000003, > 00B0y0000000004, 00B0y0000000005]> but was:<[00B0y0000000001, > 00B0y0000000002, 00B0y0000000003, 00B0y0000000004]> > > > Subsequent manual test runs went well: > > [INFO] Running org.apache.phoenix.end2end.IndexToolForNonTxGlobalIndexIT > [WARNING] Tests run: 72, Failures: 0, Errors: 0, Skipped: 4, Time elapsed: > 1,010.964 s - in org.apache.phoenix.end2end.IndexToolForNonTxGlobalIndexIT > > [INFO] Running org.apache.phoenix.end2end.ViewTTLIT > [INFO] Tests run: 26, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: > 772.233 s - in org.apache.phoenix.end2end.ViewTTLIT > > > > On 2021/02/27 00:51:06, Geoffrey Jacoby <gjac...@apache.org> wrote: > > +1 (binding) > > > > Check signatures and checksums: OK > > apache-rat:check for licenses : OK > > mvn clean install -DskipTests: OK > > mvn verify for new 2.4.1 support: OK after rerunning one crashed test > > > > Geoffrey > > > > > > On Fri, Feb 26, 2021 at 6:04 AM Istvan Toth <st...@apache.org> wrote: > > > > > Please vote on this Apache phoenix release candidate, > > > phoenix-5.1.1RC0 > > > > > > The VOTE will remain open for at least 72 hours. > > > > > > [ ] +1 Release this package as Apache phoenix 5.1.1 > > > [ ] -1 Do not release this package because ... > > > > > > The tag to be voted on is 5.1.1RC0: > > > > > > https://github.com/apache/phoenix/tree/5.1.1RC0 > > > > > > The release files, including signatures, digests, as well as CHANGES.md > > > and RELEASENOTES.md included in this RC can be found at: > > > > > > https://dist.apache.org/repos/dist/dev/phoenix/phoenix-5.1.1RC0/ > > > > > > Maven artifacts are available in a staging repository at: > > > > > > https://repository.apache.org/#stagingRepositories > > > (orgapachephoenix-1215) > > > > > > Artifacts were signed with the 0x794433C7 key which can be found in: > > > > > > https://dist.apache.org/repos/dist/release/phoenix/KEYS > > > > > > To learn more about Apache phoenix, please see > > > > > > http://phoenix.apache.org/ > > > > > > Thanks, > > > Istvan > > > > > >
