gjacoby126 commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875216816
##########
hbase-client/src/test/java/org/apache/omid/transaction/TestCellUtils.java:
##########
@@ -137,7 +136,7 @@ public void testCorrectMapingOfCellsToShadowCells() throws
IOException {
"Should be equal");
// Modify dup shadow cell to have a greater MVCC and check that is
replaced
- HBaseShims.setKeyValueSequenceId((KeyValue) dupCell1WithAnotherValue,
1);
+ ((KeyValue)dupCell1WithAnotherValue).setSequenceId(1);
Review Comment:
Should we be using ExtendedCell rather than KeyValue? (Technically they're
both IA.Private, but it at least doesn't couple us to KeyValue's on-heap
array-backed implementation)
##########
pom.xml:
##########
@@ -147,33 +146,19 @@
<properties>
-
- <hbase1.artifactId.suffix>hbase1.x</hbase1.artifactId.suffix>
- <hbase2.artifactId.suffix>hbase2.x</hbase2.artifactId.suffix>
-
-
<shims1.artifactId>omid-hbase-shims-${hbase1.artifactId.suffix}</shims1.artifactId>
-
<shims2.artifactId>omid-hbase-shims-${hbase2.artifactId.suffix}</shims2.artifactId>
-
- <!-- hbase-1 profile props are here and not in profile section to work
better with intelij-->
- <shims.artifactId>${shims1.artifactId}</shims.artifactId>
- <java.version>1.7</java.version>
- <hadoop.version>${hadoop1.version}</hadoop.version>
- <hbase.version>${hbase1.version}</hbase.version>
- <shims.module>hbase-1</shims.module>
-
<hbase.artifactId.suffix>${hbase1.artifactId.suffix}</hbase.artifactId.suffix>
+ <java.version>1.8</java.version>
+ <commons-io.version>2.11.0</commons-io.version>
<!-- Basic properties -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<!-- 3rd-Party Library Versioning -->
- <hbase1.version>1.3.1</hbase1.version>
- <hbase2.version>2.0.1</hbase2.version>
- <hadoop1.version>2.7.5</hadoop1.version>
- <hadoop2.version>3.0.0</hadoop2.version>
+ <hbase.version>2.4.12</hbase.version>
+ <hadoop.version>2.10.0</hadoop.version>
Review Comment:
We only support Hadoop 3 in Phoenix but only 2.10 in Omid? Seems like an odd
inconsistency, esp since the old hadoop2.version here is actually 3.0.0
##########
pom.xml:
##########
@@ -147,33 +146,19 @@
<properties>
-
- <hbase1.artifactId.suffix>hbase1.x</hbase1.artifactId.suffix>
- <hbase2.artifactId.suffix>hbase2.x</hbase2.artifactId.suffix>
-
-
<shims1.artifactId>omid-hbase-shims-${hbase1.artifactId.suffix}</shims1.artifactId>
-
<shims2.artifactId>omid-hbase-shims-${hbase2.artifactId.suffix}</shims2.artifactId>
-
- <!-- hbase-1 profile props are here and not in profile section to work
better with intelij-->
- <shims.artifactId>${shims1.artifactId}</shims.artifactId>
- <java.version>1.7</java.version>
- <hadoop.version>${hadoop1.version}</hadoop.version>
- <hbase.version>${hbase1.version}</hbase.version>
- <shims.module>hbase-1</shims.module>
-
<hbase.artifactId.suffix>${hbase1.artifactId.suffix}</hbase.artifactId.suffix>
+ <java.version>1.8</java.version>
+ <commons-io.version>2.11.0</commons-io.version>
<!-- Basic properties -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<!-- 3rd-Party Library Versioning -->
- <hbase1.version>1.3.1</hbase1.version>
- <hbase2.version>2.0.1</hbase2.version>
- <hadoop1.version>2.7.5</hadoop1.version>
- <hadoop2.version>3.0.0</hadoop2.version>
+ <hbase.version>2.4.12</hbase.version>
+ <hadoop.version>2.10.0</hadoop.version>
<phoenix.thirdparty.version>2.0.0</phoenix.thirdparty.version>
<guice.version>3.0</guice.version>
<testng.version>6.10</testng.version>
- <slf4j.version>1.7.7</slf4j.version>
+ <slf4j.version>1.7.30</slf4j.version>
Review Comment:
Let's go all the way up to slf4j.version 1.7.36, the latest, which
transparently uses reload4j where necessary if anything slf4j dependency tries
to pull in log4j 1.x.
##########
pom.xml:
##########
@@ -612,20 +570,28 @@
<profile>
<id>hbase-1</id>
- <!-- Empty profile to prevent warning when compiling with
-Phbase-1 -->
- </profile>
-
- <profile>
- <id>hbase-2</id>
- <properties>
- <shims.artifactId>${shims2.artifactId}</shims.artifactId>
- <shims.module>hbase-2</shims.module>
- <java.version>1.8</java.version>
- <hadoop.version>${hadoop2.version}</hadoop.version>
- <hbase.version>${hbase2.version}</hbase.version>
-
<hbase.artifactId.suffix>${hbase2.artifactId.suffix}</hbase.artifactId.suffix>
- <commons-io.version>2.11.0</commons-io.version>
- </properties>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>enforce</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <rules>
+ <AlwaysFail/>
Review Comment:
Even if this is just a draft, why AlwaysFail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
