stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875443116
##########
hbase-client/src/test/java/org/apache/omid/transaction/TestCellUtils.java:
##########
@@ -137,7 +136,7 @@ public void testCorrectMapingOfCellsToShadowCells() throws
IOException {
"Should be equal");
// Modify dup shadow cell to have a greater MVCC and check that is
replaced
- HBaseShims.setKeyValueSequenceId((KeyValue) dupCell1WithAnotherValue,
1);
+ ((KeyValue)dupCell1WithAnotherValue).setSequenceId(1);
Review Comment:
As that would be an effective code change, I think that we should track that
in a separate ticket, if you think that we should have that for 1.1. (it's only
used in tests)
I originally tried to refactor all the deprecated HBase 1.x APIs as part of
this change, but I postponed that to OMID-223 , as it's a lot of work and there
are some hairy cases, and I want to get Omid released 1.1 ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
