[
https://issues.apache.org/jira/browse/PHOENIX-6730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Istvan Toth updated PHOENIX-6730:
---------------------------------
Description:
Recently a dependabot commit has landed on connectors that upgrades the version
of protobuf-java to 3.6.1
I think that we should revert that.
Part of the HBase 2 public API is that the public coprocessors use HBase 2 for
communication.
See [https://hbase.apache.org/book.html#cpeps]
Using unshaded 3.6.1 in the connector breaks that contract.
The shaded connector artifacts do not include protobuf-java, so the change is
effectively a NOOP for the shaded connector JAR.
However, in case someone depends on the core artifact, the change in the
protobuf-java version may cause problems.
[~rajeshbabu] I know that you have added the explicit dependency for the table
metadata broadcast featrue, and that you've applied the dependabot PR, but I
think that we should stick to the protobuf pulled in by HBase.
was:
Recently a dependabot commit has landed on connectors that upgrades the version
of protobuf-java to 3.6.1
I think that we should revert that.
Part of the HBase 2 public API is that the public coprocessors use HBase 2 for
communication.
See [https://hbase.apache.org/book.html#cpeps]
Using unshaded 3.6.1 in the connector breaks that contract.
The shaded connector artifacts do not include protobuf-java, so the change is
effectively a NOOP. However, in case someone depends on the core artifact, the
change in the protobuf-java version may cause problems.
[~rajeshbabu] I know that you have added the explicit dependency for the table
metadata broadcast featre, and that you've applied the dependabot PR, but
I think that we should stick to the protobuf pulled in used by HBase.
> Revert protobuf-java version to 2.5.0
> -------------------------------------
>
> Key: PHOENIX-6730
> URL: https://issues.apache.org/jira/browse/PHOENIX-6730
> Project: Phoenix
> Issue Type: Bug
> Components: connectors, spark-connector
> Affects Versions: connectors-6.0.0
> Reporter: Istvan Toth
> Priority: Major
>
> Recently a dependabot commit has landed on connectors that upgrades the
> version of protobuf-java to 3.6.1
> I think that we should revert that.
> Part of the HBase 2 public API is that the public coprocessors use HBase 2
> for communication.
> See [https://hbase.apache.org/book.html#cpeps]
> Using unshaded 3.6.1 in the connector breaks that contract.
> The shaded connector artifacts do not include protobuf-java, so the change is
> effectively a NOOP for the shaded connector JAR.
> However, in case someone depends on the core artifact, the change in the
> protobuf-java version may cause problems.
> [~rajeshbabu] I know that you have added the explicit dependency for the
> table metadata broadcast featrue, and that you've applied the dependabot PR,
> but I think that we should stick to the protobuf pulled in by HBase.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
