[ 
https://issues.apache.org/jira/browse/OMID-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821951#comment-17821951
 ] 

ASF GitHub Bot commented on OMID-277:
-------------------------------------

stoty commented on code in PR #156:
URL: https://github.com/apache/phoenix-omid/pull/156#discussion_r1507077825


##########
pom.xml:
##########
@@ -293,6 +294,67 @@
                     </configuration>
                 </plugin>
 
+                <plugin>
+                  <groupId>org.apache.maven.plugins</groupId>
+                  <artifactId>maven-enforcer-plugin</artifactId>
+                  <dependencies>
+                    <dependency>
+                      <groupId>de.skuzzle.enforcer</groupId>
+                      <artifactId>restrict-imports-enforcer-rule</artifactId>
+                      <version>${restrict-imports.enforcer.version}</version>
+                    </dependency>
+                  </dependencies>

Review Comment:
   Straight copy-paste from Phoenix :)





> Omid 1.1.2 fails with Phoenix 5.2
> ---------------------------------
>
>                 Key: OMID-277
>                 URL: https://issues.apache.org/jira/browse/OMID-277
>             Project: Phoenix Omid
>          Issue Type: Bug
>    Affects Versions: 1.1.2
>            Reporter: Lars Hofhansl
>            Assignee: Istvan Toth
>            Priority: Major
>
> Try to create a transactional table with Phoenix 5.2 and Omid 1.1.2, and 
> you'll find this in the RS log:
> {code:java}
>  2024-02-28T20:26:13,055 ERROR [RS_OPEN_REGION-regionserver/think:16020-2] 
> coprocessor.CoprocessorHost: The coprocessor 
> org.apache.phoenix.coprocessor.OmidTransactionalProcessor threw 
> java.lang.NoClassDefFoundE
> rror: Could not initialize class 
> org.apache.omid.committable.hbase.HBaseCommitTableConfig
> java.lang.NoClassDefFoundError: Could not initialize class 
> org.apache.omid.committable.hbase.HBaseCommitTableConfig
> at 
> org.apache.omid.transaction.OmidSnapshotFilter.start(OmidSnapshotFilter.java:85)
>  ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at 
> org.apache.phoenix.coprocessor.OmidTransactionalProcessor.start(OmidTransactionalProcessor.java:44)
>  ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at 
> org.apache.hadoop.hbase.coprocessor.BaseEnvironment.startup(BaseEnvironment.java:69)
>  ~[hbase-server-2.5.7.jar:2.5.7]
> at 
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.checkAndLoadInstance(CoprocessorHost.java:285)
>  ~[hbase-server-2.5.7.jar:2.5.7]
> at 
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:249)
>  ~[hbase-server-2.5.7.jar:2.5.7]
> at 
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:200)
>  ~[hbase-server-2.5.7.jar:2.5.7]
> at 
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.loadTableCoprocessors(RegionCoprocessorHost.java:388)
>  ~[hbase-server-2.5.7.jar:2.5.7]
> at 
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.<init>(RegionCoprocessorHost.java:278)
>  ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.regionserver.HRegion.<init>(HRegion.java:859) 
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.regionserver.HRegion.<init>(HRegion.java:734) 
> ~[hbase-server-2.5.7.jar:2.5.7]
> at 
> jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
>  ~[?:?]
> at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502) 
> ~[?:?]
> at java.lang.reflect.Constructor.newInstance(Constructor.java:486) ~[?:?]
> at org.apache.hadoop.hbase.regionserver.HRegion.newHRegion(HRegion.java:6971) 
> ~[hbase-server-2.5.7.jar:2.5.7]
> at 
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegionFromTableDir(HRegion.java:7184)
>  ~[hbase-server-2.5.7.jar:2.5.7]
> at 
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7161) 
> ~[hbase-server-2.5.7.jar:2.5.7]
> at 
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7120) 
> ~[hbase-server-2.5.7.jar:2.5.7]
> at 
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7076) 
> ~[hbase-server-2.5.7.jar:2.5.7]
> at 
> org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:149)
>  ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) 
> ~[hbase-server-2.5.7.jar:2.5.7]
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
>  ~[?:?]
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
>  ~[?:?]
> at java.lang.Thread.run(Thread.java:1583) ~[?:?]
> Caused by: java.lang.ExceptionInInitializerError: Exception 
> java.lang.NoClassDefFoundError: 
> org/apache/phoenix/shaded/com/google/common/base/Charsets [in thread 
> "RS_OPEN_REGION-regionserver/think:16020-2"]
> at 
> org.apache.omid.committable.hbase.HBaseCommitTableConfig.<clinit>(HBaseCommitTableConfig.java:36)
>  ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at org.apache.omid.transaction.OmidCompactor.start(OmidCompactor.java:92) 
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at 
> org.apache.phoenix.coprocessor.OmidGCProcessor.start(OmidGCProcessor.java:43) 
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> ... 21 more{code}
>  
> As before I have no time to track this down as I do not work on Phoenix/HBase 
> anymore, but at least I can file an issue. :)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to