[
https://issues.apache.org/jira/browse/OMID-279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Istvan Toth updated OMID-279:
-----------------------------
Description:
The waitStrategy setup code looks confused and ambiguous:
https://github.com/apache/phoenix-omid/blob/91260e355d0e6c004420eef6cead2cda3dbc8971/tso-server/src/main/java/org/apache/omid/tso/DisruptorModule.java#L42
In the LOW_CPU case we perform the exact same bind twice, in the
HIGH_TRHOUGHPUT case we bind two different strategies to the same name, and
it's not obvious which one gets actually used.
was:
The waitStrategy setup code looks confused and ambiguous:
https://github.com/apache/phoenix-omid/blob/91260e355d0e6c004420eef6cead2cda3dbc8971/tso-server/src/main/java/org/apache/omid/tso/DisruptorModule.java#L42
In the LOW_CPU case perform th exact same bind twice, in the HIGH_TRHOUGHPUT
case we bind two different strategies to the same name, and it's not obvious
which one gets actually used.
> Disruptor waitstrategy setup problems
> -------------------------------------
>
> Key: OMID-279
> URL: https://issues.apache.org/jira/browse/OMID-279
> Project: Phoenix Omid
> Issue Type: Bug
> Affects Versions: 1.1.2
> Reporter: Istvan Toth
> Priority: Major
>
> The waitStrategy setup code looks confused and ambiguous:
> https://github.com/apache/phoenix-omid/blob/91260e355d0e6c004420eef6cead2cda3dbc8971/tso-server/src/main/java/org/apache/omid/tso/DisruptorModule.java#L42
> In the LOW_CPU case we perform the exact same bind twice, in the
> HIGH_TRHOUGHPUT case we bind two different strategies to the same name, and
> it's not obvious which one gets actually used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
