[
https://issues.apache.org/jira/browse/OMID-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833017#comment-17833017
]
ASF GitHub Bot commented on OMID-289:
-------------------------------------
stoty commented on PR #160:
URL: https://github.com/apache/phoenix-omid/pull/160#issuecomment-2031124386
The change looks good.
I'd prefer to rename the ticket and commit to something like
"Add additional asserts in TestOmid..."
You can always add more checks in a test, so this is more of an improvement
than a fix.
> Fix missing assertions for TestOmidClientConfiguration.java
> -----------------------------------------------------------
>
> Key: OMID-289
> URL: https://issues.apache.org/jira/browse/OMID-289
> Project: Phoenix Omid
> Issue Type: Test
> Reporter: Nikita Pande
> Assignee: Nikita Pande
> Priority: Minor
>
> Adding missing assert statement missing for TestOmidClientConfiguration.java
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
