[
https://issues.apache.org/jira/browse/PHOENIX-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chaijunjie updated PHOENIX-7316:
--------------------------------
Description:
After PHOENIX-6560, we find there are also many Statement not closed...
1. org.apache.phoenix.schema.MetaDataClient
incrementStatement
linkStatement
setAsync
setSync
tableUpsert
linkStatement
incrementStatement
tableUpsert
2. org.apache.phoenix.schema.task.Task
org.apache.phoenix.schema.task.Task#populateTasks
org.apache.phoenix.schema.task.Task#executeStatementAndGetTaskMutations
3.
org.apache.phoenix.jdbc.PhoenixStatement.ExecutableShowTablesStatement#compilePlan
4. org.apache.phoenix.trace.PhoenixMetricsSink
org.apache.phoenix.trace.PhoenixMetricsSink#createTable
org.apache.phoenix.trace.PhoenixMetricsSink#putMetrics
5. org.apache.phoenix.trace.TraceWriter.FlushMetrics#addToBatch
6. org.apache.phoenix.trace.TraceWriter#createTable
7. org.apache.phoenix.trace.TraceReader#readAll
8.
org.apache.phoenix.mapreduce.index.automation.PhoenixMRJobSubmitter#getCandidateJobs
so may be right, i will raise a PR try to fix all
was:
After PHOENIX-6560, we find there are also many PreparedStatement not closed...
1. org.apache.phoenix.schema.MetaDataClient
incrementStatement
linkStatement
setAsync
setSync
tableUpsert
linkStatement
incrementStatement
tableUpsert
2. org.apache.phoenix.schema.task.Task
org.apache.phoenix.schema.task.Task#populateTasks
org.apache.phoenix.schema.task.Task#executeStatementAndGetTaskMutations
3.
org.apache.phoenix.jdbc.PhoenixStatement.ExecutableShowTablesStatement#compilePlan
4. org.apache.phoenix.trace.PhoenixMetricsSink
org.apache.phoenix.trace.PhoenixMetricsSink#createTable
org.apache.phoenix.trace.PhoenixMetricsSink#putMetrics
5. org.apache.phoenix.trace.TraceWriter.FlushMetrics#addToBatch
6. org.apache.phoenix.trace.TraceWriter#createTable
7. org.apache.phoenix.trace.TraceReader#readAll
8.
org.apache.phoenix.mapreduce.index.automation.PhoenixMRJobSubmitter#getCandidateJobs
so may be right, i will raise a PR try to fix all
> Need close more Statements
> --------------------------
>
> Key: PHOENIX-7316
> URL: https://issues.apache.org/jira/browse/PHOENIX-7316
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.2.0
> Reporter: chaijunjie
> Priority: Major
>
> After PHOENIX-6560, we find there are also many Statement not closed...
> 1. org.apache.phoenix.schema.MetaDataClient
> incrementStatement
> linkStatement
> setAsync
> setSync
> tableUpsert
> linkStatement
> incrementStatement
> tableUpsert
> 2. org.apache.phoenix.schema.task.Task
> org.apache.phoenix.schema.task.Task#populateTasks
> org.apache.phoenix.schema.task.Task#executeStatementAndGetTaskMutations
> 3.
> org.apache.phoenix.jdbc.PhoenixStatement.ExecutableShowTablesStatement#compilePlan
> 4. org.apache.phoenix.trace.PhoenixMetricsSink
> org.apache.phoenix.trace.PhoenixMetricsSink#createTable
> org.apache.phoenix.trace.PhoenixMetricsSink#putMetrics
> 5. org.apache.phoenix.trace.TraceWriter.FlushMetrics#addToBatch
> 6. org.apache.phoenix.trace.TraceWriter#createTable
> 7. org.apache.phoenix.trace.TraceReader#readAll
> 8.
> org.apache.phoenix.mapreduce.index.automation.PhoenixMRJobSubmitter#getCandidateJobs
>
> so may be right, i will raise a PR try to fix all
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
