Hi, Forgive my ignorance of Spark:
REMOVE DATASOURCE V1: IIRC the V1 and V2 datasources have different names. Wouldn't this break applications using the old V1 name ? Is there a chance that this would break old applications ? BUILD ARTIFACTS WITH DIFFERENT SCALA VERSIONS: Is this required because scala 2.x runtimes are not backwards compatible ? I don't see a problem with that. Its utility is limited until we start providing actual releases and publish binary artifacts, but in theory I agree. The implementation would be a bit tricky, the solution that comes to my mind is generating the artifacts in multiple maven runs with different profiles, like we do for the different HBase profiles now. Istvan On Fri, Aug 23, 2024 at 7:36 PM Rejeb Ben Rejeb <benrejebre...@gmail.com> wrote: > Hi, > > I would like to start a discussion about two changes to the phoenix5-spark > and phoenix5-spark3. > > REMOVE DATASOURCE V1 > It is not longer necessarie to keep Datasource V1 classes, since all > features are implemented in new connector version classes. T > When fixing the issue PHOENIX-6783, I checked for impacts and done some > modifications to make removing the classes safe and without impacts. > > BUILD ARTIFACTS WITH DIFFERENT SCALA VERSIONS > phoenix5-spark2 connector uses spark-2.4.8 wich is available with scala > 2.11 and scala 2.12. > Same for phoenix5-spark3 uses spark-3.2.4 wich is available with scala 2.12 > and scala 2.13. > > It would be nice to have connector supporting both scala version like other > connectors for exemple mongoDB or cassandra. > > Thanks, > Rejeb >
