[
https://issues.apache.org/jira/browse/OMID-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940917#comment-17940917
]
ASF GitHub Bot commented on OMID-309:
-------------------------------------
stoty commented on code in PR #188:
URL: https://github.com/apache/phoenix-omid/pull/188#discussion_r2028425630
##########
tso-server/bin/omid.sh:
##########
@@ -39,6 +46,12 @@ for j in ../lib/*.jar; do
CLASSPATH=$CLASSPATH:$j
done
+if [ -z ${OMID_OPTS+x} ]; then
Review Comment:
The problem is that both may have similar options, like -Xmx, in which case
it depends on the JVM version if the first or last one gets used.
That's why I want to make sure that HBASE_OPTS is a fallback to OMID_OPTS
rather than using both.
Phoenix currently adds both, but I also want to fix that one, because of the
possible conflicting options.
> Load hbase-env.sh and fall back to HBASE_OPT in startup scripts
> ---------------------------------------------------------------
>
> Key: OMID-309
> URL: https://issues.apache.org/jira/browse/OMID-309
> Project: Phoenix Omid
> Issue Type: Improvement
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> Omid needs the HBase client environment variables and cli options like FIPS
> switches and the java.security.auth.login.config system property.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
