[
https://issues.apache.org/jira/browse/PHOENIX-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908991#comment-13908991
]
ASF GitHub Bot commented on PHOENIX-68:
---------------------------------------
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/9#discussion_r9966869
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/JoinCompiler.java ---
@@ -135,7 +140,7 @@ private JoinSpec(SelectStatement statement,
ColumnResolver resolver) throws SQLE
if (!(tableNode instanceof JoinTableNode))
throw new SQLFeatureNotSupportedException("Implicit
joins not supported.");
JoinTableNode joinTableNode = (JoinTableNode) tableNode;
- JoinTable joinTable = new JoinTable(joinTableNode,
tableRefIter.next(), selectList, resolver);
+ JoinTable joinTable = new JoinTable(joinTableNode,
tableRefIter.next(), selectList, hint, resolver);
--- End diff --
To try to keep args down, how about passing through the SelectStatement
instead of selectList and hint, as you can get both of them from that?
> Add Option "FAVOR_STAR_JOIN" to indicate if star join optimization is
> preferred for multi inner join queries
> ------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-68
> URL: https://issues.apache.org/jira/browse/PHOENIX-68
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Reporter: Maryann Xue
> Assignee: Maryann Xue
> Priority: Minor
> Fix For: 3.0.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> We enable an option called "FAVOR_STAR_JOIN" to allow for choosing different
> execution plans for multi inner join queries.
> For example:
> select * from A inner join B on A.ab_id = B.ab_id inner join C on A.ac_id =
> C.ac_id and B.bc_id = C.bc_id;
> When using star-join optimization, the execution steps will be like:
> hash B, hash C --> join A
> If star-join is turned off, the execution steps will be like:
> hash A --> join B --> hash temp result AB --> join C
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
