[
https://issues.apache.org/jira/browse/PHOENIX-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13916566#comment-13916566
]
ASF GitHub Bot commented on PHOENIX-85:
---------------------------------------
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/10#discussion_r10185785
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/cache/TenantCacheImpl.java ---
@@ -82,9 +82,17 @@ public Closeable getServerCache(ImmutableBytesPtr
cacheId) {
@Override
public Closeable addServerCache(ImmutableBytesPtr cacheId,
ImmutableBytesWritable cachePtr, ServerCacheFactory cacheFactory) throws
SQLException {
MemoryChunk chunk =
this.getMemoryManager().allocate(cachePtr.getLength());
- Closeable element = cacheFactory.newCache(cachePtr, chunk);
- getServerCaches().put(cacheId, element);
- return element;
+ try {
--- End diff --
Agree. Thanks!
> Refine error handling in HashJoinPlan execution and add warnings
> ----------------------------------------------------------------
>
> Key: PHOENIX-85
> URL: https://issues.apache.org/jira/browse/PHOENIX-85
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Reporter: Maryann Xue
> Assignee: Maryann Xue
> Priority: Trivial
> Fix For: 3.0.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Remove all hash cache spontaneously if any of the sub-query execution raises
> an exception.
> Compare the end time of each sub-query execution with the earliest finished
> sub-query execution. If the time difference is greater than the "max server
> cache live time", warn users that the earlier hash caches on the server might
> have expired and have been removed.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
