[ 
https://issues.apache.org/jira/browse/PHOENIX-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919292#comment-13919292
 ] 

Hudson commented on PHOENIX-53:
-------------------------------

FAILURE: Integrated in Apache Phoenix - Branch:master #101 (See 
[https://builds.apache.org/job/Phoenix/101/])
PHOENIX-53 Replace CSV loader with Apache Commons CSV loader (JamesViolette) 
(jamestaylor: rev 3ed0f61428b9aa3cc077a33e3cb4b0891ef37d71)
* phoenix-core/src/test/java/org/apache/phoenix/end2end/CSVLoaderTest.java
* phoenix-core/src/main/java/org/apache/phoenix/util/CSVCommonsLoader.java
* 
phoenix-core/src/test/java/org/apache/phoenix/end2end/CSVCommonsLoaderTest.java
* phoenix-core/src/main/java/org/apache/phoenix/map/reduce/MapReduceJob.java
* phoenix-core/src/main/java/org/apache/phoenix/util/PhoenixRuntime.java
* phoenix-core/src/main/java/org/apache/phoenix/util/CSVLoader.java
* phoenix-core/pom.xml
* phoenix-core/lib/commons-csv-1.0-SNAPSHOT.jar


> Replace CSV loader with Apache Commons CSV loader
> -------------------------------------------------
>
>                 Key: PHOENIX-53
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-53
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 2.2.3, 3.0.0
>            Reporter: James Violette
>              Labels: patch
>             Fix For: 2.2.3, 3.0.0
>
>         Attachments: commons-csv-1.0-SNAPSHOT.jar, 
> incubator-phoenix-commons-csv-rev1.patch, 
> incubator-phoenix-commons-csv-rev2-3.0.0.patch, 
> incubator-phoenix-commons-csv-rev2-3.0.0.patch, 
> incubator-phoenix-csv-commons.patch
>
>
> in org.apache.phoenix.util.CSVLoader, the upsert fails if it encounters an 
> empty line.  This occurs if all lines end with the new line character and the 
> reader returns an empty line at the end.
> A fix is to add a guard while reading the next line.
>       public void upsert(CSVReader reader) throws Exception {
>    ...
>               while ((nextLine = reader.readNext()) != null) {
>                       if (nextLine.length==0) {
>                               continue;
>                       }



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to