[
https://issues.apache.org/jira/browse/PHOENIX-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920225#comment-13920225
]
James Violette commented on PHOENIX-53:
---------------------------------------
Was there a change from forced upper case identifiers to mixed case identifiers
on the server side?
The CSVCommonsLoader does not change the case of any identifiers.
The full stack trace is only three lines of code. CSVCommonsLoader relies on
DatabaseMetaData to retrieve metadata. If that finds not columns, then the
stack trace follows. The patch only changed how CSV records were loaded and
parsed from the file system. It did not change the control flow, nor did it add
much in the way of error checking, beyond what I found necessary for a CSV file
with headers.
Could we move this discussion to a separate thread, if we agree this issue is
not related to this patch? Perhaps one related to mixed chase vs. forced upper
case identifiers. It would be helpful to add a Jira issue that would add
PhoenixRuntime commandline tests, and another to add more error checking /
logging / status reporting to PhoenixRuntime, and CSVCommonsLoader logic.
> Replace CSV loader with Apache Commons CSV loader
> -------------------------------------------------
>
> Key: PHOENIX-53
> URL: https://issues.apache.org/jira/browse/PHOENIX-53
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 2.2.3, 3.0.0
> Reporter: James Violette
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: colInfoToString.patch,
> commons-csv-1.0-SNAPSHOT-sources.jar, commons-csv-1.0-SNAPSHOT.jar,
> csvloaderoverrides.diff, csvloadersource.diff,
> incubator-phoenix-commons-csv-rev2-3.0.0.patch
>
>
> in org.apache.phoenix.util.CSVLoader, the upsert fails if it encounters an
> empty line. This occurs if all lines end with the new line character and the
> reader returns an empty line at the end. Other issues, such as encapsulated
> meta characters also occur.
> The fix is to replace the opencsv library with the current apache commons-csv
> library.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
