[ 
https://issues.apache.org/jira/browse/PHOENIX-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923462#comment-13923462
 ] 

Hudson commented on PHOENIX-119:
--------------------------------

FAILURE: Integrated in Apache Phoenix - Branch:master #116 (See 
[https://builds.apache.org/job/Phoenix/116/])
PHOENIX-119 Removed unnecessary Expression.getByteSize() method (jamestaylor: 
rev d43adc62c22285a59f692fcd3d9567d5f287c287)
* 
phoenix-core/src/test/java/org/apache/phoenix/arithmetic/ArithmeticOperationTest.java
* 
phoenix-core/src/main/java/org/apache/phoenix/expression/function/SubstrFunction.java
* 
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionlessQueryServicesImpl.java
* 
phoenix-core/src/test/java/org/apache/phoenix/filter/SkipScanFilterIntersectTest.java
* phoenix-core/src/main/java/org/apache/phoenix/schema/PDatum.java
* phoenix-core/src/test/java/org/apache/phoenix/schema/ValueBitSetTest.java
* phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java
* phoenix-core/src/main/java/org/apache/phoenix/schema/PBaseColumn.java
* phoenix-core/src/main/java/org/apache/phoenix/compile/WhereOptimizer.java
* 
phoenix-core/src/main/java/org/apache/phoenix/expression/function/PrefixFunction.java
* 
phoenix-core/src/main/java/org/apache/phoenix/query/DelegateConnectionQueryServices.java
* 
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/SequenceRegionObserver.java
* phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java
* phoenix-core/src/main/java/org/apache/phoenix/schema/RowKeyValueAccessor.java
* 
phoenix-core/src/main/java/org/apache/phoenix/expression/MultiplyExpression.java
* 
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java
* phoenix-core/src/test/java/org/apache/phoenix/util/ScanUtilTest.java
* 
phoenix-core/src/main/java/org/apache/phoenix/expression/LiteralExpression.java
* 
phoenix-core/src/main/java/org/apache/phoenix/expression/RowKeyColumnExpression.java
* 
phoenix-core/src/main/java/org/apache/phoenix/compile/CreateSequenceCompiler.java
* 
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
* phoenix-core/src/main/java/org/apache/phoenix/schema/DelegateDatum.java
* phoenix-core/src/test/java/org/apache/phoenix/filter/SkipScanFilterTest.java
* phoenix-core/src/main/java/org/apache/phoenix/compile/ProjectionCompiler.java
* phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
* phoenix-core/src/test/java/org/apache/phoenix/compile/ScanRangesTest.java
* 
phoenix-core/src/main/java/org/apache/phoenix/expression/DecimalAddExpression.java
* 
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixParameterMetaData.java
* phoenix-core/src/main/java/org/apache/phoenix/expression/BaseExpression.java
* 
phoenix-core/src/main/java/org/apache/phoenix/expression/ComparisonExpression.java
* phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java
* 
phoenix-core/src/main/java/org/apache/phoenix/expression/function/CoalesceFunction.java
* 
phoenix-core/src/main/java/org/apache/phoenix/expression/function/RTrimFunction.java
* 
phoenix-core/src/main/java/org/apache/phoenix/expression/function/LTrimFunction.java
* 
phoenix-core/src/main/java/org/apache/phoenix/expression/RowValueConstructorExpression.java
* phoenix-core/src/main/java/org/apache/phoenix/schema/PColumnImpl.java
* 
phoenix-core/src/main/java/org/apache/phoenix/expression/DecimalSubtractExpression.java
* phoenix-core/src/main/java/org/apache/phoenix/expression/ColumnExpression.java
* 
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixResultSetMetaData.java
* 
phoenix-core/src/main/java/org/apache/phoenix/expression/function/ArrayIndexFunction.java
* 
phoenix-core/src/test/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataTest.java
* 
phoenix-core/src/main/java/org/apache/phoenix/expression/function/TrimFunction.java
* phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java
* phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java
* phoenix-core/src/main/java/org/apache/phoenix/compile/LimitCompiler.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/ColumnDef.java
* phoenix-core/src/main/java/org/apache/phoenix/expression/DivideExpression.java
* phoenix-core/src/main/java/org/apache/phoenix/expression/CaseExpression.java
* 
phoenix-core/src/main/java/org/apache/phoenix/expression/function/InvertFunction.java
* 
phoenix-core/src/main/java/org/apache/phoenix/expression/function/RoundDateExpression.java
* phoenix-core/src/main/java/org/apache/phoenix/schema/Sequence.java
* phoenix-core/src/test/java/org/apache/phoenix/end2end/UpsertValuesTest.java
* phoenix-core/src/main/java/org/apache/phoenix/util/SchemaUtil.java
* 
phoenix-core/src/test/java/org/apache/phoenix/end2end/SkipRangeParallelIteratorRegionSplitterTest.java
* phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java
* 
phoenix-core/src/main/java/org/apache/phoenix/expression/function/RegexpSubstrFunction.java
* phoenix-core/src/main/java/org/apache/phoenix/expression/CoerceExpression.java
* phoenix-core/src/main/java/org/apache/phoenix/schema/ValueSchema.java
* 
phoenix-core/src/main/java/org/apache/phoenix/expression/BaseAddSubtractExpression.java
* 
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServices.java
* 
phoenix-core/src/main/java/org/apache/phoenix/expression/function/MD5Function.java
* phoenix-core/src/main/java/org/apache/phoenix/schema/PDataType.java


> Removed unnecessary Expression.getByteSize() method
> ---------------------------------------------------
>
>                 Key: PHOENIX-119
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-119
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: James Taylor
>             Fix For: 3.0.0
>
>         Attachments: expr-cleanup.patch
>
>
> The Expression.getByteSize() method is not needed, as the combination of 
> Expression.getMaxLength() and Expression.getDataType() give you all the 
> information you need.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to